Re: [PR] Miscellaneous cleanups [datafusion]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #17189:
URL: https://github.com/apache/datafusion/pull/17189#discussion_r2367511032


##########
datafusion/common/src/dfschema.rs:
##########
@@ -899,6 +899,7 @@ impl TryFrom<SchemaRef> for DFSchema {
             field_qualifiers: vec![None; field_count],
             functional_dependencies: FunctionalDependencies::empty(),
         };
+        dfschema.check_names()?;

Review Comment:
   FWIW it seems this has caused a regression for some users in 50.0.0 (there are some code paths that violate an invariant). See https://github.com/apache/datafusion/pull/17706



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org