You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/04 16:12:31 UTC

[GitHub] [airflow] ashb opened a new pull request #16270: Ignore airflow/_vendor for building python API docs

ashb opened a new pull request #16270:
URL: https://github.com/apache/airflow/pull/16270


   On 3.6 it's slower than needed, but on Py 3.8 it causes a doc build error (on a type comment of all things)
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #16270: Ignore airflow/_vendor for building python API docs

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #16270:
URL: https://github.com/apache/airflow/pull/16270#discussion_r645694819



##########
File path: docs/conf.py
##########
@@ -594,7 +594,7 @@ def _get_params(root_schema: dict, prefix: str = "", default_section: str = "")
 
 # A list of patterns to ignore when finding files
 autoapi_ignore = [
-    'airflow/configuration/',

Review comment:
       This folder doesn't exist anymore, and without the leading `*` it never matched anything anyway.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb merged pull request #16270: Ignore airflow/_vendor for building python API docs

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #16270:
URL: https://github.com/apache/airflow/pull/16270


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org