You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by andreaturli <gi...@git.apache.org> on 2017/08/25 16:03:07 UTC

[GitHub] brooklyn-server pull request #805: Modify jcloudsLocation.releaseNode

GitHub user andreaturli opened a pull request:

    https://github.com/apache/brooklyn-server/pull/805

    Modify jcloudsLocation.releaseNode

    Workaround waiting for a fix for https://issues.apache.org/jira/browse/JCLOUDS-1332
    
    Uses `destroyNodesMatchingId` instead of `destroyNode` as it consistently invokes `cleanUpIncidentalResourcesOfDeadNodes`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andreaturli/brooklyn-server fix/jclouds-location-releaseNode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/805.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #805
    
----
commit 53c0d4408270a2aafab803c8e8ff5300f3fa38e9
Author: Andrea Turli <an...@gmail.com>
Date:   2017-08-25T15:58:45Z

    Modify jcloudsLocation.releaseNode
    
    - from destroyNode to destroyNodesMatchingId as it calls consistently cleanUpIncidentalResourcesOfDeadNodes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #805: Modify jcloudsLocation.releaseNode

Posted by drigodwin <gi...@git.apache.org>.

Github user drigodwin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/805
  
    This PR swaps the mechanism Brooklyn is using to destroy a node to one which is less tested within Brooklyn. The problem it addresses has been fixed upstream in jclouds so assuming we can incorporate that in before the next release we should not need this PR. 
    
    I think however we should leave this PR open and unmerged in the meantime in case the jclouds release is not available and this fix has not been incorporated before the next release.


---

[GitHub] brooklyn-server issue #805: Modify jcloudsLocation.releaseNode

Posted by drigodwin <gi...@git.apache.org>.

Github user drigodwin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/805
  
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #805: Modify jcloudsLocation.releaseNode

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/805


---

[GitHub] brooklyn-server issue #805: Modify jcloudsLocation.releaseNode

Posted by aledsage <gi...@git.apache.org>.

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/805
  
    @andreaturli code LGTM - thanks! Nice and simple fix for an annoying problem.
    
    I've not tested it myself. If you or someone else has done so on appropriate cloud(s), then very happy for you to do so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #805: Modify jcloudsLocation.releaseNode

Posted by duncangrant <gi...@git.apache.org>.

Github user duncangrant commented on the issue:

    https://github.com/apache/brooklyn-server/pull/805
  
    Should the same change be applied to killMachine( as well?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---