You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Srikanth Sundarrajan <sr...@hotmail.com> on 2015/09/25 07:33:21 UTC
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review100531
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 506)
<https://reviews.apache.org/r/35379/#comment157752>
gData is already populated with Global section data. Is this necessary ?
- Srikanth Sundarrajan
On July 21, 2015, 10:59 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 10:59 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>
Re: Review Request 35379: OOZIE-2030 Configuration properties from
global
section is not getting set in Hadoop job conf when using sub-workflow
action in Oozie workflow.xml
Posted by Jaydeep Vishwakarma <ja...@gmail.com>.
> On Sept. 25, 2015, 5:33 a.m., Srikanth Sundarrajan wrote:
> > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java, line 507
> > <https://reviews.apache.org/r/35379/diff/7/?file=1017729#file1017729line507>
> >
> > gData is already populated with Global section data. Is this necessary ?
Yes, it is necesarry, When jobConf.get(OOZIE_GLOBAL) have global conf , we have have to merge it with current global conf.
- Jaydeep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35379/#review100531
-----------------------------------------------------------
On July 21, 2015, 10:59 a.m., Jaydeep Vishwakarma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35379/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 10:59 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2030
> https://issues.apache.org/jira/browse/OOZIE-2030
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> Forwarding global conf from workflow to action when action is subworkflow,
> subworkflow storing it to property and forwarding as property.
> LiteworkflowAppParser handling all condition and ensuring child level pass of global conf.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 854d621
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java d3a6523
> core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 9ab897a
>
> Diff: https://reviews.apache.org/r/35379/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Jaydeep Vishwakarma
>
>