You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/05/16 16:23:21 UTC
[kudu-CR] [security-faults-itest] fixes on test flakiness
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6895
Change subject: [security-faults-itest] fixes on test flakiness
......................................................................
[security-faults-itest] fixes on test flakiness
Couple of updates to make the test less flaky:
* Added --tablet_transaction_memory_limit_mb=-1 option to get rid of
tserver crashes due to a bug in memory accounting.
* Increased TTL of Kerberos ticket to 120 seconds: in case of inferior
VMs the test sometimes could not make a couple of smoke test
iterations in ~60 seconds.
* Enabled newly introduced --rpc_reopen_outbound_connections flag
to make servers authenticate the client upon every RPC call.
Test results prior to this fix with --stress_cpu_threads=8
(DEBUG build, 18 out of 1024 fail):
http://dist-test.cloudera.org//job?job_id=aserbin.1494950598.5510
Test results after this fix --stress_cpu_threads=8
(DEBUG build, 0 out of 1024 fail):
http://dist-test.cloudera.org//job?job_id=aserbin.1494948803.23142
Change-Id: I4f3ff1c65cd695a367e52804dae951e1b962452d
---
M src/kudu/integration-tests/security-faults-itest.cc
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/6895/1
--
To view, visit http://gerrit.cloudera.org:8080/6895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f3ff1c65cd695a367e52804dae951e1b962452d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [security-faults-itest] fixes on test flakiness
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security-faults-itest] fixes on test flakiness
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6895/1//COMMIT_MSG
Commit Message:
PS1, Line 11: * Added --tablet_transaction_memory_limit_mb=-1 option to get rid of
: tserver crashes due to a bug in memory accounting.
> we chatted about this on slack. seems like this is trying to work around KU
Exactly. Now, since the fix for KUDU-1294 is in the master branch, that flag can be safely removed.
--
To view, visit http://gerrit.cloudera.org:8080/6895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3ff1c65cd695a367e52804dae951e1b962452d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security-faults-itest] fixes on test flakiness
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [security-faults-itest] fixes on test flakiness
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3ff1c65cd695a367e52804dae951e1b962452d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security-faults-itest] fixes on test flakiness
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [security-faults-itest] fixes on test flakiness
......................................................................
[security-faults-itest] fixes on test flakiness
Couple of updates to make the test less flaky and have more coverage:
* Increased TTL of Kerberos ticket to 120 seconds: in case of inferior
VMs the test sometimes could not make a couple of smoke test
iterations in ~60 seconds.
* Enabled newly introduced --rpc_reopen_outbound_connections flag
to make servers authenticate the client upon every RPC call.
Test results prior to this fix with --stress_cpu_threads=8
(DEBUG build, 18 out of 1024 fail):
http://dist-test.cloudera.org//job?job_id=aserbin.1494950598.5510
Test results after this fix --stress_cpu_threads=8
(DEBUG build, 0 out of 1024 fail):
http://dist-test.cloudera.org//job?job_id=aserbin.1494948803.23142
Change-Id: I4f3ff1c65cd695a367e52804dae951e1b962452d
---
M src/kudu/integration-tests/security-faults-itest.cc
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/6895/2
--
To view, visit http://gerrit.cloudera.org:8080/6895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f3ff1c65cd695a367e52804dae951e1b962452d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security-faults-itest] fixes on test flakiness
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security-faults-itest] fixes on test flakiness
......................................................................
Patch Set 1: Verified+1
Unrelated flake in MultiThreadedTabletTest/4.DeleteAndReinsert
--
To view, visit http://gerrit.cloudera.org:8080/6895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3ff1c65cd695a367e52804dae951e1b962452d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security-faults-itest] fixes on test flakiness
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [security-faults-itest] fixes on test flakiness
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6895/1//COMMIT_MSG
Commit Message:
PS1, Line 11: * Added --tablet_transaction_memory_limit_mb=-1 option to get rid of
: tserver crashes due to a bug in memory accounting.
we chatted about this on slack. seems like this is trying to work around KUDU-1294 but actually isn't a fully successful workaround (can cause heap-use-after-free, right?) Perhaps we should fix.
--
To view, visit http://gerrit.cloudera.org:8080/6895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3ff1c65cd695a367e52804dae951e1b962452d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security-faults-itest] fixes on test flakiness
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [security-faults-itest] fixes on test flakiness
......................................................................
[security-faults-itest] fixes on test flakiness
Couple of updates to make the test less flaky and have more coverage:
* Increased TTL of Kerberos ticket to 120 seconds: in case of inferior
VMs the test sometimes could not make a couple of smoke test
iterations in ~60 seconds.
* Enabled newly introduced --rpc_reopen_outbound_connections flag
to make servers authenticate the client upon every RPC call.
Test results prior to this fix with --stress_cpu_threads=8
(DEBUG build, 18 out of 1024 fail):
http://dist-test.cloudera.org//job?job_id=aserbin.1494950598.5510
Test results after this fix --stress_cpu_threads=8
(DEBUG build, 0 out of 1024 fail):
http://dist-test.cloudera.org//job?job_id=aserbin.1494948803.23142
Change-Id: I4f3ff1c65cd695a367e52804dae951e1b962452d
Reviewed-on: http://gerrit.cloudera.org:8080/6895
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/security-faults-itest.cc
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f3ff1c65cd695a367e52804dae951e1b962452d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>