You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/09 17:19:29 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3313: Use take for like comparisons

tustvold commented on code in PR #3313:
URL: https://github.com/apache/arrow-rs/pull/3313#discussion_r1044662895


##########
arrow-string/src/like.rs:
##########
@@ -214,7 +215,10 @@ pub fn like_utf8_scalar_dyn(
         DataType::Dictionary(_, _) => {
             downcast_dictionary_array!(
                 left => {
-                    like_dict_scalar(left, right)
+                    let dict_comparison = like_utf8_scalar_dyn(left.values().as_ref(), right)?;

Review Comment:
   The duplication is slightly unfortunate, but will hopefully get cleaned up as part of #3296 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org