You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/09/02 05:04:54 UTC
Review Request 38038: Use guava replacement for
ExecutorServiceShutdown.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38038/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Use guava replacement for ExecutorServiceShutdown.
Diffs
-----
commons/src/main/java/org/apache/aurora/common/util/concurrent/ExecutorServiceShutdown.java 7aad9efe60b4caf3ca96c1c8101df6230f8589cc
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java ad78432a6595d32582cb0e920900e4bcb21df8dc
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 1a25924d789295c5950947f5e302e1d1fbec68f2
src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java 07ea19a8f020bb0e4de71031685acd0e3879b8e2
src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 2c03238d14a861401fbe88c25923122b60bcc6b5
src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java 947a50f6e298fa9cafd3eb2c68147796f54394ab
Diff: https://reviews.apache.org/r/38038/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 38038: Use guava replacement for
ExecutorServiceShutdown.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38038/#review97391
-----------------------------------------------------------
Ship it!
Master (07838c3) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 2, 2015, 3:04 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38038/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 3:04 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use guava replacement for ExecutorServiceShutdown.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/util/concurrent/ExecutorServiceShutdown.java 7aad9efe60b4caf3ca96c1c8101df6230f8589cc
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java ad78432a6595d32582cb0e920900e4bcb21df8dc
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 1a25924d789295c5950947f5e302e1d1fbec68f2
> src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java 07ea19a8f020bb0e4de71031685acd0e3879b8e2
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 2c03238d14a861401fbe88c25923122b60bcc6b5
> src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java 947a50f6e298fa9cafd3eb2c68147796f54394ab
>
> Diff: https://reviews.apache.org/r/38038/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 38038: Use guava replacement for
ExecutorServiceShutdown.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38038/#review97390
-----------------------------------------------------------
Ship it!
I'm not on the people line but this change LGTM.
- Zameer Manji
On Sept. 1, 2015, 8:04 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38038/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 8:04 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use guava replacement for ExecutorServiceShutdown.
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/util/concurrent/ExecutorServiceShutdown.java 7aad9efe60b4caf3ca96c1c8101df6230f8589cc
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java ad78432a6595d32582cb0e920900e4bcb21df8dc
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 1a25924d789295c5950947f5e302e1d1fbec68f2
> src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java 07ea19a8f020bb0e4de71031685acd0e3879b8e2
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 2c03238d14a861401fbe88c25923122b60bcc6b5
> src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java 947a50f6e298fa9cafd3eb2c68147796f54394ab
>
> Diff: https://reviews.apache.org/r/38038/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>