You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/03/01 13:19:15 UTC
[GitHub] [arrow-datafusion] jackwener opened a new pull request, #5440: minor: fix clippy in nightly.
jackwener opened a new pull request, #5440:
URL: https://github.com/apache/arrow-datafusion/pull/5440
# Which issue does this PR close?
N/A
# Rationale for this change
# What changes are included in this PR?
fix clippy in nightly.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5440: minor: fix clippy in nightly.
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5440:
URL: https://github.com/apache/arrow-datafusion/pull/5440#issuecomment-1450748701
Benchmark runs are scheduled for baseline = 3c1e4c0fd23012afa00dfd05a0571b61023b3d21 and contender = f9f40bf70a9b6af4345f16b906bcf8a839d5f511. f9f40bf70a9b6af4345f16b906bcf8a839d5f511 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6860bb40dadc4a6aa51a08c098b4dcd6...1b4714005f2645078fad111322e5acc2/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f0aac3ff8f2348cfb979e0b27a57772e...80a31aaeda1b4065877cc148c824f017/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/47543a6a9ced41529445e0cf290033ab...a82f89c8a2bd43a598e5f2dadd5d0c45/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d9b57a3ff53849058369f53b510cb346...5551eebb2e5f4c30b8931594f7218c46/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #5440: minor: fix clippy in nightly.
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #5440:
URL: https://github.com/apache/arrow-datafusion/pull/5440#issuecomment-1450144964
BTW, there is more error in `cargo clippy` of nightly.
```
error[E0428]: the name `ALLOC` is defined multiple times
--> benchmarks/src/bin/tpch.rs:62:1
|
58 | static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
| ------------------------------------------------------------ previous definition of the value `ALLOC` here
...
62 | static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `ALLOC` redefined here
|
= note: `ALLOC` must be defined only once in the value namespace of this module
error: cannot define multiple global allocators
--> benchmarks/src/bin/tpch.rs:62:1
|
58 | static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
| ------------------------------------------------------------ previous global allocator defined here
...
61 | #[global_allocator]
| ------------------- in this procedural macro expansion
62 | static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot define a new global allocator
|
= note: this error originates in the attribute macro `global_allocator` (in Nightly builds, run with -Z macro-backtrace for more info)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5440: minor: fix clippy in nightly.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5440:
URL: https://github.com/apache/arrow-datafusion/pull/5440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org