You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by xiaoqi951109 <gi...@git.apache.org> on 2018/03/08 03:20:46 UTC
[GitHub] incubator-weex pull request #1055: [android] support resize Image in FrescoI...
GitHub user xiaoqi951109 opened a pull request:
https://github.com/apache/incubator-weex/pull/1055
[android] support resize Image in FrescoImageAdapter
the default ImageAdapter Supported By Picasso, so a ImgUri with Base64 is not supported ,but resize in Image is not useful in FrescoImageAdapter , so i support it
First of all, thank you for your contribution!
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
<!--
How to use github markdown?
### checkable example
- [x] checked
- [ ] not checked
More github Markdown info to see https://guides.github.com/features/mastering-markdown/
-->
CheckList:
**if** *isBugFix* **:**
* [ ] Make sure that you add at least one unit test for the bug which you had fixed.
**elif** *isNewFeature* **:**
* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [ ] Update test scripts for the feature.
* [ ] Add unit tests for the feature.
<!--
（请在***提交***前删除这段描述）
Notes: Weex will move into Apache Software Foundation (ASF) on Feb 24 2017.
Our new GitHub repo is https://github.com/apache/incubator-weex
After Feb 24 2017, we only accept pull requests from https://github.com/apache/incubator-weex
Thank you for your support.
----
注意：Weex 将于 2017-02-24 迁移至 Apache 基金会
届时我们会使用新的 GitHub 仓库：https://github.com/apache/incubator-weex 并在那里继续接受大家的 pull request。
更多详情请关注：https://github.com/weexteam/article/issues/130
感谢理解和支持
-->
<!--
（请在***提交***前删除这段描述）
It's ***RECOMMENDED*** to submit typo fix, new demo, tiny bugfix and large feature to `master` branch.
See [Branch Strategy](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management) for more detail.
----
错别字修改、新 demo、较小的 bugfix、甚至较大的功能都可以直接提到 `master` 分支；
查看完整的[分支策略 (英文)](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)。
-->
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xiaoqi951109/incubator-weex resize_in_Fresco
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1055.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1055
----
commit 200677fa010d09fe2ea15951c230e3e62e4c304e
Author: xiaoqi951109 <26...@...>
Date: 2018-03-08T03:18:58Z
[android] support resize Image in FrescoImageAdapter
the default ImageAdapter Supported By Picasso, so a ImgUri with Base64 is not supported ,but resize in Image is not useful in FrescoImageAdapter , so i support it
----
---
[GitHub] incubator-weex issue #1055: [android] support resize Image in FrescoImageAda...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1055
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex issue #1055: [android] support resize Image in FrescoImageAda...
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/1055
hi @xiaoqi951109 thanks for your contribution and @misakuo can you review this pull request
---