You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "asubiotto (via GitHub)" <gi...@apache.org> on 2023/11/28 12:02:26 UTC

[I] [Go]: Code should avoid calling schema.Fields where possible [arrow]

asubiotto opened a new issue, #38918:
URL: https://github.com/apache/arrow/issues/38918

   ### Describe the enhancement requested
   
   https://github.com/apache/arrow/pull/35307 changed schema.Fields to return a copy of the fields for safety:
   https://github.com/apache/arrow/blob/c614014db805caf3bbc4d5270bd990c095bf8725/go/arrow/schema.go#L198
   
   However, a big part of the codebase continues to use schema.Fields assuming it is zero-allocation. We should review all callsites and change to using `NumFields` in cases where we only need the number of fields and looping over the field indices rather than the result of `schema.Fields`.
   
   ### Component(s)
   
   Go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Go]: Code should avoid calling schema.Fields where possible [arrow]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed issue #38918: [Go]: Code should avoid calling schema.Fields where possible
URL: https://github.com/apache/arrow/issues/38918


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org