You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@struts.apache.org by lu...@apache.org on 2017/06/05 06:51:25 UTC

[1/2] struts git commit: WW-4801 Only one hidden field per checkboxlist.

Repository: struts
Updated Branches:
  refs/heads/master 8e9f9fb89 -> 0100a6beb


WW-4801 Only one hidden field per checkboxlist. 

Project: http://git-wip-us.apache.org/repos/asf/struts/repo
Commit: http://git-wip-us.apache.org/repos/asf/struts/commit/46153e78
Tree: http://git-wip-us.apache.org/repos/asf/struts/tree/46153e78
Diff: http://git-wip-us.apache.org/repos/asf/struts/diff/46153e78

Branch: refs/heads/master
Commit: 46153e78da63c7da40d0dbd410de1e5f25b462ab
Parents: 2fb431d
Author: gregh <gr...@gmail.com>
Authored: Tue May 30 15:02:23 2017 +0100
Committer: gregh <gr...@gmail.com>
Committed: Tue May 30 15:02:23 2017 +0100

----------------------------------------------------------------------
 .../views/java/simple/CheckboxListHandler.java  | 26 ++++++++++----------
 1 file changed, 13 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/struts/blob/46153e78/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxListHandler.java
----------------------------------------------------------------------
diff --git a/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxListHandler.java b/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxListHandler.java
index 3914b30..9240938 100644
--- a/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxListHandler.java
+++ b/plugins/javatemplates/src/main/java/org/apache/struts2/views/java/simple/CheckboxListHandler.java
@@ -84,22 +84,22 @@ public class CheckboxListHandler extends AbstractTagHandler implements TagGenera
                     characters(itemValueStr);
                 super.end("label");
 
-                // Hidden input section
-                a = new Attributes();
-                a.add("type", "hidden")
-                        .add("id",
-                                "__multiselect_"
-                                        + StringUtils.defaultString(StringEscapeUtils.escapeHtml4(id)))
-                        .add("name",
-                                "__multiselect_"
-                                        + StringUtils.defaultString(StringEscapeUtils.escapeHtml4(name)))
-                        .add("value", "").addIfTrue("disabled", disabled);
-                start("input", a);
-                end("input");
-
                 stack.pop();
                 cnt++;
             }
+
+            // Hidden input section
+            Attributes a = new Attributes();
+            a.add("type", "hidden")
+                    .add("id",
+                            "__multiselect_"
+                                    + StringUtils.defaultString(StringEscapeUtils.escapeHtml4(id)))
+                    .add("name",
+                            "__multiselect_"
+                                    + StringUtils.defaultString(StringEscapeUtils.escapeHtml4(name)))
+                    .add("value", "").addIfTrue("disabled", disabled);
+            start("input", a);
+            end("input");
         }
     }
 


[2/2] struts git commit: WW-4801 fixes duplicated hidden field in checkboxListHandler

Posted by lu...@apache.org.
WW-4801 fixes duplicated hidden field in checkboxListHandler


Project: http://git-wip-us.apache.org/repos/asf/struts/repo
Commit: http://git-wip-us.apache.org/repos/asf/struts/commit/0100a6be
Tree: http://git-wip-us.apache.org/repos/asf/struts/tree/0100a6be
Diff: http://git-wip-us.apache.org/repos/asf/struts/diff/0100a6be

Branch: refs/heads/master
Commit: 0100a6bebf90062ee4356dd170caa3047892b601
Parents: 8e9f9fb 46153e7
Author: Lukasz Lenart <lu...@apache.org>
Authored: Mon Jun 5 08:51:19 2017 +0200
Committer: Lukasz Lenart <lu...@apache.org>
Committed: Mon Jun 5 08:51:19 2017 +0200

----------------------------------------------------------------------
 .../views/java/simple/CheckboxListHandler.java  | 26 ++++++++++----------
 1 file changed, 13 insertions(+), 13 deletions(-)
----------------------------------------------------------------------