You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by se...@apache.org on 2019/11/02 17:52:56 UTC
[calcite] branch site updated: Site: Append '(FirstName LastName)'
to commit message example in contributing section
This is an automated email from the ASF dual-hosted git repository.
sereda pushed a commit to branch site
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/site by this push:
new 317cc7f Site: Append '(FirstName LastName)' to commit message example in contributing section
317cc7f is described below
commit 317cc7fb46e0d8c52e921c8a0fd2eaa52900740f
Author: Andrei Sereda <25...@users.noreply.github.com>
AuthorDate: Sat Nov 2 13:37:39 2019 -0400
Site: Append '(FirstName LastName)' to commit message example in contributing section
Frequently during reviews I have to ask new contributors to add their full name
in commit message. It's more likely that existing committers are already familiar with
Calcite code / commit conventions than new-joiners therefore documentation examples
should be more tailored towards "first-timers".
---
site/develop/index.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/site/develop/index.md b/site/develop/index.md
index 39b2162..ded23ea 100644
--- a/site/develop/index.md
+++ b/site/develop/index.md
@@ -136,7 +136,7 @@ Commit your change to your branch, and use a comment that starts with
the JIRA case number, like this:
{% highlight text %}
-[CALCITE-345] AssertionError in RexToLixTranslator comparing to date literal
+[CALCITE-345] AssertionError in RexToLixTranslator comparing to date literal (FirstName LastName)
{% endhighlight %}
If your change had multiple commits, use `git rebase -i master` to