[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.

[GitBox <gi...@apache.org>]

Fine0830 commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r691991324



##########
File path: src/utils/queryParameter.ts
##########
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export const getQueryParameter = (name: string) => {

Review comment:
       Please use passing Props to Route Components rather than this

##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -22,7 +22,12 @@ limitations under the License. -->
         </svg>
         <div class="mb-5 ell" v-tooltip:top.ellipsis="i.name || ''">
           <span class="calls sm mr-10">{{ i.value }}</span>
-          <span class="cp link-hover">{{ i.name + getTraceId(i) }}</span>
+          <span class="cp link-hover">
+            <a v-if="i.url" :href="i.url" target="_blank">

Review comment:
       You should use `router-link`.
   
   ```suggestion
         <router-link :to="{ name: 'trace',  query: {... } }">...</router-link>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org