You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/08/26 14:13:53 UTC
Review Request 25061: HDP-artifacts tmp directory should not be used
at all
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25061/
-----------------------------------------------------------
Review request for Ambari and Dmytro Sen.
Bugs: AMBARI-7012
https://issues.apache.org/jira/browse/AMBARI-7012
Repository: ambari
Description
-------
Ambari should no longer use /tmp/HDP-artifacts
Noticed it in here, there might be other places:
<https://github.com/apache/ambari/blob/trunk/ambari-
server/src/main/resources/custom_actions/check_host.py>
In any case, we should not be naming this DIR HDP-artifacts, since it's not
HDP specific, it's ambari. This should change to AMBARI-artifacts if for some
reason it has to stay in use.
Diffs
-----
ambari-server/src/main/resources/custom_actions/check_host.py 3543f96
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py c7b01d6
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py ce8f34b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ef26418
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py c7b01d6
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py bb4ee71
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 8a82717
ambari-server/src/test/python/TestCheckHost.py c20f428
ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_metastore.py 1fbe8ec
ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 24cb274
ambari-server/src/test/python/stacks/1.3.2/hooks/before-ANY/test_before_any.py fe623a5
ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py 653b47c
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 653e764
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8eb6bd2
ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py 3abfa57
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 9dfcff2
ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fd4ee43
ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 648913b
Diff: https://reviews.apache.org/r/25061/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 25061: HDP-artifacts tmp directory should not be
used at all
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25061/#review51522
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Авг. 26, 2014, 12:33 п.п., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25061/
> -----------------------------------------------------------
>
> (Updated Авг. 26, 2014, 12:33 п.п.)
>
>
> Review request for Ambari and Dmytro Sen.
>
>
> Bugs: AMBARI-7012
> https://issues.apache.org/jira/browse/AMBARI-7012
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari should no longer use /tmp/HDP-artifacts
>
> Noticed it in here, there might be other places:
>
> <https://github.com/apache/ambari/blob/trunk/ambari-
> server/src/main/resources/custom_actions/check_host.py>
>
> In any case, we should not be naming this DIR HDP-artifacts, since it's not
> HDP specific, it's ambari. This should change to AMBARI-artifacts if for some
> reason it has to stay in use.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/check_host.py 3543f96
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py c7b01d6
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py ce8f34b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ef26418
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py c7b01d6
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py bb4ee71
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 8a82717
> ambari-server/src/test/python/TestCheckHost.py c20f428
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_metastore.py 1fbe8ec
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 24cb274
> ambari-server/src/test/python/stacks/1.3.2/hooks/before-ANY/test_before_any.py fe623a5
> ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py 653b47c
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 653e764
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8eb6bd2
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py 3abfa57
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 9dfcff2
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fd4ee43
>
> Diff: https://reviews.apache.org/r/25061/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 25061: HDP-artifacts tmp directory should not be
used at all
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25061/
-----------------------------------------------------------
(Updated Aug. 26, 2014, 12:33 p.m.)
Review request for Ambari and Dmytro Sen.
Bugs: AMBARI-7012
https://issues.apache.org/jira/browse/AMBARI-7012
Repository: ambari
Description
-------
Ambari should no longer use /tmp/HDP-artifacts
Noticed it in here, there might be other places:
<https://github.com/apache/ambari/blob/trunk/ambari-
server/src/main/resources/custom_actions/check_host.py>
In any case, we should not be naming this DIR HDP-artifacts, since it's not
HDP specific, it's ambari. This should change to AMBARI-artifacts if for some
reason it has to stay in use.
Diffs (updated)
-----
ambari-server/src/main/resources/custom_actions/check_host.py 3543f96
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py c7b01d6
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py ce8f34b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ef26418
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py c7b01d6
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py bb4ee71
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 8a82717
ambari-server/src/test/python/TestCheckHost.py c20f428
ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_metastore.py 1fbe8ec
ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 24cb274
ambari-server/src/test/python/stacks/1.3.2/hooks/before-ANY/test_before_any.py fe623a5
ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py 653b47c
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 653e764
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8eb6bd2
ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py 3abfa57
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 9dfcff2
ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fd4ee43
Diff: https://reviews.apache.org/r/25061/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 25061: HDP-artifacts tmp directory should not be
used at all
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25061/#review51520
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Авг. 26, 2014, 12:13 п.п., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25061/
> -----------------------------------------------------------
>
> (Updated Авг. 26, 2014, 12:13 п.п.)
>
>
> Review request for Ambari and Dmytro Sen.
>
>
> Bugs: AMBARI-7012
> https://issues.apache.org/jira/browse/AMBARI-7012
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari should no longer use /tmp/HDP-artifacts
>
> Noticed it in here, there might be other places:
>
> <https://github.com/apache/ambari/blob/trunk/ambari-
> server/src/main/resources/custom_actions/check_host.py>
>
> In any case, we should not be naming this DIR HDP-artifacts, since it's not
> HDP specific, it's ambari. This should change to AMBARI-artifacts if for some
> reason it has to stay in use.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/custom_actions/check_host.py 3543f96
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py c7b01d6
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py ce8f34b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/scripts/params.py ef26418
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py c7b01d6
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py bb4ee71
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py 8a82717
> ambari-server/src/test/python/TestCheckHost.py c20f428
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_metastore.py 1fbe8ec
> ambari-server/src/test/python/stacks/1.3.2/HIVE/test_hive_server.py 24cb274
> ambari-server/src/test/python/stacks/1.3.2/hooks/before-ANY/test_before_any.py fe623a5
> ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py 653b47c
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 653e764
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8eb6bd2
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py 3abfa57
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py 9dfcff2
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py fd4ee43
> ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/package/scripts/params.py 648913b
>
> Diff: https://reviews.apache.org/r/25061/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>