You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/06/02 09:35:35 UTC

[GitHub] [hadoop] jianghuazhu commented on pull request #3376: HDFS-16208. Support Delete API with FGL.

jianghuazhu commented on PR #3376:
URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1144654653

   Hi @prasad-acit , nice to talk to you.
   For delete using FGL, it may be safer to add child locks before fsn.removeLeasesAndINodes().
   ![image](https://user-images.githubusercontent.com/6416939/171601462-987130b2-5d0f-4576-9bd7-b6c7173c1c29.png)
   
   The reason here is that after finishing running unprotectedDelete(), there are still updated content, such as block-related updates, and snapshotManager deletes Snapshottable.
   Before this, this was done while holding the FSNamesystemLock.
   Based on the premise of safety, I make my proposal.
   If my suggestion is wrong, please ignore it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org