You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "enlohhy (via GitHub)" <gi...@apache.org> on 2026/05/12 09:08:13 UTC

[PR] feat(deckgl): take over geojson point radius controls [superset]

enlohhy opened a new pull request, #40046:
URL: https://github.com/apache/superset/pull/40046

   ### SUMMARY
   
   Takes over the GeoJSON point radius controls work from #33247 into a fork-based branch so it can continue moving forward.
   
   This carries over the same three user-facing pieces from the existing PR:
   
   - adds a new `Point Radius` control
   - adds a new `Point Radius Units` control
   - keeps `Point Radius Scale`, but makes it work with more intuitive defaults
   
   It also preserves the backward-compatibility follow-up from the earlier review:
   
   - existing charts without the new fields fall back to deck.gl defaults
   - new charts still get the improved control-panel defaults
   - tests cover both legacy and new-chart behavior
   
   ### TESTING INSTRUCTIONS
   
   1. Create a GeoJSON chart with point features.
   2. In the chart controls, verify you can set `Point Radius`, `Point Radius Units`, and `Point Radius Scale`.
   3. Check that:
      - small values like `1`, `5`, or `10` work with `Pixels`
      - `Meters` scales with zoom
      - older charts without the new saved fields keep their prior behavior
   
   ### ADDITIONAL INFORMATION
   
   - Follow-up/takeover of #33247
   - Related bounty issue: #34398
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(deckgl): take over geojson point radius controls [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #40046: feat(deckgl): take over geojson point radius controls
URL: https://github.com/apache/superset/pull/40046


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(deckgl): take over geojson point radius controls [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40046:
URL: https://github.com/apache/superset/pull/40046#issuecomment-4445139770

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40046?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 64.09%. Comparing base ([`460992d`](https://app.codecov.io/gh/apache/superset/commit/460992d89b33ba07f3a22cb9a5b4cd83c27a768c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`99629b5`](https://app.codecov.io/gh/apache/superset/commit/99629b5f11e40bf5cbf645d112fcc6350722340b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 45 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #40046      +/-   ##
   ==========================================
   + Coverage   64.08%   64.09%   +0.01%     
   ==========================================
     Files        2590     2590              
     Lines      137964   137967       +3     
     Branches    31998    32001       +3     
   ==========================================
   + Hits        88409    88433      +24     
   + Misses      48037    48016      -21     
     Partials     1518     1518              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/40046/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/40046/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.02% <100.00%> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40046?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(deckgl): take over geojson point radius controls [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40046:
URL: https://github.com/apache/superset/pull/40046#issuecomment-4428982638

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(deckgl): take over geojson point radius controls [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #40046:
URL: https://github.com/apache/superset/pull/40046#issuecomment-4774314705

   @enlohhy Heads up, #33247, the PR this was taking over, has since merged, so the GeoJSON point radius controls are already on master. I think this one's been overtaken. Is there anything here it's still missing? I'll close it, but ping me if you think there's more value here and we should reopen/revisit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org