You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by er...@apache.org on 2012/04/02 13:16:10 UTC
svn commit: r1308301 - /ofbiz/trunk/framework/base/build.xml
Author: erwan
Date: Mon Apr 2 11:16:10 2012
New Revision: 1308301
URL: http://svn.apache.org/viewvc?rev=1308301&view=rev
Log:
Seems using ./ant for running install and tests is not detecting the class for cobertura. Testing if the jar is present is making it right. Resolves OFBIZ-4757
Modified:
ofbiz/trunk/framework/base/build.xml
Modified: ofbiz/trunk/framework/base/build.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/build.xml?rev=1308301&r1=1308300&r2=1308301&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/build.xml (original)
+++ ofbiz/trunk/framework/base/build.xml Mon Apr 2 11:16:10 2012
@@ -72,7 +72,7 @@ under the License.
</condition>
<condition property="exclude.cobertura" value="org/ofbiz/base/config/Cobertura*.java">
<not>
- <available classname="net.sourceforge.cobertura.instrument.ClassInstrumenter" classpathref="local.class.path"/>
+ <available property="exclude.cobertura" file="lib/cobertura-1.9.4.1.jar"/>
</not>
</condition>
<patternset id="src.exc.set">
Re: svn commit: r1308301 - /ofbiz/trunk/framework/base/build.xml
Posted by Scott Gray <sc...@hotwaxmedia.com>.
The problem with work-arounds is that they often hide a real problem by covering it with more bad code. The best thing to do IMO is to create a jira with a work-around patch and then leave things as they are until someone can fix it. A bug encourages a fix, a work-around discourages it. Then multiple this problem by the hundreds of times we've taken this approach in OFBiz.
I'm speaking in general terms though, I don't use cobertura.
Regards
Scott
On 3/04/2012, at 6:43 AM, Pierre Smits wrote:
> Hi Adrian,
>
> You are right in calling it a hack. I would call it a work around. Please
> feel free to create the JIRA for the underlying issue. As for now I would
> appreciate it when the hack stays in as the work around until somebody
> picks up the JIRA for the underlying issue and solves it.
>
> Regards,
>
> Pierre
>
> Op 2 april 2012 14:42 schreef Adrian Crum <
> adrian.crum@sandglass-software.com> het volgende:
>
>> This looks like a hack. It would be preferable to find out why ./ant can't
>> find the class.
>>
>> -Adrian
>>
>>
>> On 4/2/2012 12:16 PM, erwan@apache.org wrote:
>>
>>> Author: erwan
>>> Date: Mon Apr 2 11:16:10 2012
>>> New Revision: 1308301
>>>
>>> URL: http://svn.apache.org/viewvc?**rev=1308301&view=rev<http://svn.apache.org/viewvc?rev=1308301&view=rev>
>>> Log:
>>> Seems using ./ant for running install and tests is not detecting the
>>> class for cobertura. Testing if the jar is present is making it right.
>>> Resolves OFBIZ-4757
>>>
>>> Modified:
>>> ofbiz/trunk/framework/base/**build.xml
>>>
>>> Modified: ofbiz/trunk/framework/base/**build.xml
>>> URL: http://svn.apache.org/viewvc/**ofbiz/trunk/framework/base/**
>>> build.xml?rev=1308301&r1=**1308300&r2=1308301&view=diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/build.xml?rev=1308301&r1=1308300&r2=1308301&view=diff>
>>> ==============================**==============================**
>>> ==================
>>> --- ofbiz/trunk/framework/base/**build.xml (original)
>>> +++ ofbiz/trunk/framework/base/**build.xml Mon Apr 2 11:16:10 2012
>>> @@ -72,7 +72,7 @@ under the License.
>>> </condition>
>>> <condition property="exclude.cobertura"
>>> value="org/ofbiz/base/config/**Cobertura*.java">
>>> <not>
>>> -<available classname="net.sourceforge.**cobertura.instrument.**ClassInstrumenter"
>>> classpathref="local.class.**path"/>
>>> +<available property="exclude.cobertura" file="lib/cobertura-1.9.4.1.**
>>> jar"/>
>>> </not>
>>> </condition>
>>> <patternset id="src.exc.set">
>>>
>>>
>>>
Re: svn commit: r1308301 - /ofbiz/trunk/framework/base/build.xml
Posted by Pierre Smits <pi...@gmail.com>.
Hi Adrian,
You are right in calling it a hack. I would call it a work around. Please
feel free to create the JIRA for the underlying issue. As for now I would
appreciate it when the hack stays in as the work around until somebody
picks up the JIRA for the underlying issue and solves it.
Regards,
Pierre
Op 2 april 2012 14:42 schreef Adrian Crum <
adrian.crum@sandglass-software.com> het volgende:
> This looks like a hack. It would be preferable to find out why ./ant can't
> find the class.
>
> -Adrian
>
>
> On 4/2/2012 12:16 PM, erwan@apache.org wrote:
>
>> Author: erwan
>> Date: Mon Apr 2 11:16:10 2012
>> New Revision: 1308301
>>
>> URL: http://svn.apache.org/viewvc?**rev=1308301&view=rev<http://svn.apache.org/viewvc?rev=1308301&view=rev>
>> Log:
>> Seems using ./ant for running install and tests is not detecting the
>> class for cobertura. Testing if the jar is present is making it right.
>> Resolves OFBIZ-4757
>>
>> Modified:
>> ofbiz/trunk/framework/base/**build.xml
>>
>> Modified: ofbiz/trunk/framework/base/**build.xml
>> URL: http://svn.apache.org/viewvc/**ofbiz/trunk/framework/base/**
>> build.xml?rev=1308301&r1=**1308300&r2=1308301&view=diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/build.xml?rev=1308301&r1=1308300&r2=1308301&view=diff>
>> ==============================**==============================**
>> ==================
>> --- ofbiz/trunk/framework/base/**build.xml (original)
>> +++ ofbiz/trunk/framework/base/**build.xml Mon Apr 2 11:16:10 2012
>> @@ -72,7 +72,7 @@ under the License.
>> </condition>
>> <condition property="exclude.cobertura"
>> value="org/ofbiz/base/config/**Cobertura*.java">
>> <not>
>> -<available classname="net.sourceforge.**cobertura.instrument.**ClassInstrumenter"
>> classpathref="local.class.**path"/>
>> +<available property="exclude.cobertura" file="lib/cobertura-1.9.4.1.**
>> jar"/>
>> </not>
>> </condition>
>> <patternset id="src.exc.set">
>>
>>
>>
Re: svn commit: r1308301 - /ofbiz/trunk/framework/base/build.xml
Posted by Erwan de FERRIERES <er...@gmail.com>.
2012/4/2 Adrian Crum <ad...@sandglass-software.com>:
> This looks like a hack. It would be preferable to find out why ./ant can't
> find the class.
>
I couldn't find a better solution. If anyone has one, this would be
great. I faced the same problem as Pierre, when wanting to use the
shipped ant.
> -Adrian
>
> On 4/2/2012 12:16 PM, erwan@apache.org wrote:
>>
>> Author: erwan
>> Date: Mon Apr 2 11:16:10 2012
>> New Revision: 1308301
>>
>> URL: http://svn.apache.org/viewvc?rev=1308301&view=rev
>> Log:
>> Seems using ./ant for running install and tests is not detecting the class
>> for cobertura. Testing if the jar is present is making it right. Resolves
>> OFBIZ-4757
>>
>> Modified:
>> ofbiz/trunk/framework/base/build.xml
>>
>> Modified: ofbiz/trunk/framework/base/build.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/build.xml?rev=1308301&r1=1308300&r2=1308301&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/framework/base/build.xml (original)
>> +++ ofbiz/trunk/framework/base/build.xml Mon Apr 2 11:16:10 2012
>> @@ -72,7 +72,7 @@ under the License.
>> </condition>
>> <condition property="exclude.cobertura"
>> value="org/ofbiz/base/config/Cobertura*.java">
>> <not>
>> -<available
>> classname="net.sourceforge.cobertura.instrument.ClassInstrumenter"
>> classpathref="local.class.path"/>
>> +<available property="exclude.cobertura"
>> file="lib/cobertura-1.9.4.1.jar"/>
>> </not>
>> </condition>
>> <patternset id="src.exc.set">
>>
>>
>
--
Erwan de FERRIERES
Re: svn commit: r1308301 - /ofbiz/trunk/framework/base/build.xml
Posted by Adrian Crum <ad...@sandglass-software.com>.
This looks like a hack. It would be preferable to find out why ./ant
can't find the class.
-Adrian
On 4/2/2012 12:16 PM, erwan@apache.org wrote:
> Author: erwan
> Date: Mon Apr 2 11:16:10 2012
> New Revision: 1308301
>
> URL: http://svn.apache.org/viewvc?rev=1308301&view=rev
> Log:
> Seems using ./ant for running install and tests is not detecting the class for cobertura. Testing if the jar is present is making it right. Resolves OFBIZ-4757
>
> Modified:
> ofbiz/trunk/framework/base/build.xml
>
> Modified: ofbiz/trunk/framework/base/build.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/build.xml?rev=1308301&r1=1308300&r2=1308301&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/base/build.xml (original)
> +++ ofbiz/trunk/framework/base/build.xml Mon Apr 2 11:16:10 2012
> @@ -72,7 +72,7 @@ under the License.
> </condition>
> <condition property="exclude.cobertura" value="org/ofbiz/base/config/Cobertura*.java">
> <not>
> -<available classname="net.sourceforge.cobertura.instrument.ClassInstrumenter" classpathref="local.class.path"/>
> +<available property="exclude.cobertura" file="lib/cobertura-1.9.4.1.jar"/>
> </not>
> </condition>
> <patternset id="src.exc.set">
>
>