You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/12/04 21:19:19 UTC

Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63340/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 1:19 p.m.)


Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.


Changes
-------

Rebased. Used variable instead of hard-coded protobuf version.


Repository: mesos


Description
-------

Moved Java build code to `java/CMakeLists.txt`.


Diffs (updated)
-----

  src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88 
  src/java/CMakeLists.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/63340/diff/3/

Changes: https://reviews.apache.org/r/63340/diff/2-3/


Testing
-------

Built with `-DENABLE_JAVA=ON` and attached Marathon framework to `master` (which requries Java bindings). Also built and ran `mesos-tests` with the ZooKeeper unit tests (which use the Java components).

Had to add `mesos-protobufs` as a dependency to `mesos-jar` to be totally correct.


Thanks,

Andrew Schwartzmeyer


Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

> On Dec. 4, 2017, 1:26 p.m., Joseph Wu wrote:
> > You should mention in the commit description the slight modifications you made in the code movement: All code source paths were updated to the new path (i.e. `java/src/org/apache/mesos/Executor.java` -> `src/org/apache/mesos/Executor.java`).

Good point! Will fix when committing.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63340/#review192764
-----------------------------------------------------------


On Dec. 4, 2017, 1:19 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63340/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 1:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved Java build code to `java/CMakeLists.txt`.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88 
>   src/java/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63340/diff/3/
> 
> 
> Testing
> -------
> 
> Built with `-DENABLE_JAVA=ON` and attached Marathon framework to `master` (which requries Java bindings). Also built and ran `mesos-tests` with the ZooKeeper unit tests (which use the Java components).
> 
> Had to add `mesos-protobufs` as a dependency to `mesos-jar` to be totally correct.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63340/#review192764
-----------------------------------------------------------


Ship it!




You should mention in the commit description the slight modifications you made in the code movement: All code source paths were updated to the new path (i.e. `java/src/org/apache/mesos/Executor.java` -> `src/org/apache/mesos/Executor.java`).

- Joseph Wu


On Dec. 4, 2017, 1:19 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63340/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 1:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved Java build code to `java/CMakeLists.txt`.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88 
>   src/java/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63340/diff/3/
> 
> 
> Testing
> -------
> 
> Built with `-DENABLE_JAVA=ON` and attached Marathon framework to `master` (which requries Java bindings). Also built and ran `mesos-tests` with the ZooKeeper unit tests (which use the Java components).
> 
> Had to add `mesos-protobufs` as a dependency to `mesos-jar` to be totally correct.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63340/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 4:13 p.m.)


Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park.


Changes
-------

Add updated test results. Re-verifying Java build on Windows.


Repository: mesos


Description
-------

Moved Java build code to `java/CMakeLists.txt`.


Diffs
-----

  src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88 
  src/java/CMakeLists.txt PRE-CREATION 


Diff: https://reviews.apache.org/r/63340/diff/3/


Testing (updated)
-------

Built with `-DENABLE_JAVA=ON` and attached Marathon framework to `master` (which requries Java bindings). Also built and ran `mesos-tests` with the ZooKeeper unit tests (which use the Java components).

Had to add `mesos-protobufs` as a dependency to `mesos-jar` to be totally correct.

Update: thought I was going crazy seeing these:

```
[  FAILED  ] 5 tests, listed below:
[  FAILED  ] ExamplesTest.JavaFramework
[  FAILED  ] ExamplesTest.JavaException
[  FAILED  ] ExamplesTest.JavaLog
[  FAILED  ] ExamplesTest.V0JavaFramework
[  FAILED  ] ExamplesTest.V1JavaFramework
```

but then remembered these are expected to fail as we still don't yet build the example java JAR file.

```
# TODO(andschwa): Build the Example JAR.
set(EXAMPLE_JAR_SRC
  ../examples/java/TestExceptionFramework.java
  ../examples/java/TestExecutor.java
  ../examples/java/TestFramework.java
  ../examples/java/TestLog.java
  ../examples/java/TestMultipleExecutorsFramework.java
  ../examples/java/V1TestFramework.java)
```


Thanks,

Andrew Schwartzmeyer