You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/08/06 13:56:45 UTC
[GitHub] [camel] hokutor opened a new pull request #5940: CAMEL-16852 - Moved ServiceKeys model to camel-huaweicloud-common
hokutor opened a new pull request #5940:
URL: https://github.com/apache/camel/pull/5940
Move https://github.com/apache/camel/blob/main/components/camel-huawei/camel-huaweicloud-iam/src/main/java/org/apache/camel/component/huaweicloud/iam/models/ServiceKeys.java model to be common and shared between all the huawei cloud components. Currently there is a duplicated copy in all individual component modules.
Reference: Conversation at https://camel.zulipchat.com/#narrow/stream/257298-camel/topic/Common.20package.20for.20HuaweiCloud.20components
CAMEL-16852 - Moved ServiceKeys model to camel-huaweicloud-common
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] hokutor commented on pull request #5940: CAMEL-16852 - Moved ServiceKeys model to camel-huaweicloud-common
Posted by GitBox <gi...@apache.org>.
hokutor commented on pull request #5940:
URL: https://github.com/apache/camel/pull/5940#issuecomment-894505513
> The component seems to be missing from components/pom, also we need to check the docs generation in camel-package-maven-plugin, because this components set is an exception.
Can you advice on the action to be done for this from my end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] hokutor commented on a change in pull request #5940: CAMEL-16852 - Moved ServiceKeys model to camel-huaweicloud-common
Posted by GitBox <gi...@apache.org>.
hokutor commented on a change in pull request #5940:
URL: https://github.com/apache/camel/pull/5940#discussion_r684479365
##########
File path: docs/components/modules/ROOT/pages/hwcloud-iam-component.adoc
##########
@@ -1,7 +1,7 @@
[[hwcloud-iam-component]]
= Huawei Identity and Access Management (IAM) Component
//THIS FILE IS COPIED: EDIT THE SOURCE FILE:
-:page-source: components/camel-huawei/camel-huaweicloud-iam/src/main/docs/hwcloud-iam-component.adoc
+:page-source: componentscamel-huaweicamel-huaweicloud-iamsrcmaindocshwcloud-iam-component.adoc
Review comment:
Have run the mvn routines from a mac/linux platform. Should look good now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #5940: CAMEL-16852 - Moved ServiceKeys model to camel-huaweicloud-common
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #5940:
URL: https://github.com/apache/camel/pull/5940#issuecomment-894771137
Have you look in
https://github.com/apache/camel/blob/main/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] hokutor commented on pull request #5940: CAMEL-16852 - Moved ServiceKeys model to camel-huaweicloud-common
Posted by GitBox <gi...@apache.org>.
hokutor commented on pull request #5940:
URL: https://github.com/apache/camel/pull/5940#issuecomment-895250497
> Have you look in
> https://github.com/apache/camel/blob/main/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/PrepareCatalogMojo.java
Perfect! thanks @davsclaus for pointing that. PrepareCatalogMojo updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #5940: CAMEL-16852 - Moved ServiceKeys model to camel-huaweicloud-common
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #5940:
URL: https://github.com/apache/camel/pull/5940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a change in pull request #5940: CAMEL-16852 - Moved ServiceKeys model to camel-huaweicloud-common
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #5940:
URL: https://github.com/apache/camel/pull/5940#discussion_r684456486
##########
File path: docs/components/modules/ROOT/pages/hwcloud-iam-component.adoc
##########
@@ -1,7 +1,7 @@
[[hwcloud-iam-component]]
= Huawei Identity and Access Management (IAM) Component
//THIS FILE IS COPIED: EDIT THE SOURCE FILE:
-:page-source: components/camel-huawei/camel-huaweicloud-iam/src/main/docs/hwcloud-iam-component.adoc
+:page-source: componentscamel-huaweicamel-huaweicloud-iamsrcmaindocshwcloud-iam-component.adoc
Review comment:
This is wrong, because you're on Windows I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org