You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2013/01/02 02:19:09 UTC
svn commit: r1427616 -
/lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java
Author: markrmiller
Date: Wed Jan 2 01:19:08 2013
New Revision: 1427616
URL: http://svn.apache.org/viewvc?rev=1427616&view=rev
Log:
tests: fix - only do this check if there are actually different docs
Modified:
lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java
Modified: lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java?rev=1427616&r1=1427615&r2=1427616&view=diff
==============================================================================
--- lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java (original)
+++ lucene/dev/trunk/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java Wed Jan 2 01:19:08 2013
@@ -1018,13 +1018,15 @@ public abstract class AbstractFullDistri
Set<Map> differences = showDiff(controlDocList, cloudDocList,"controlDocList","cloudDocList");
// get versions for the mismatched ids
+ boolean foundId = false;
StringBuilder ids = new StringBuilder("id:(");
for (Map doc : differences) {
ids.append(" "+doc.get("id"));
+ foundId = true;
}
ids.append(")");
- if (ids.length() > 0) {
+ if (foundId) {
// get versions for those ids that don't match
q = params("q", ids.toString(), "rows", "100000", "fl", "id,_version_",
"sort", "id asc", "tests",