You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liujianhuiouc <gi...@git.apache.org> on 2017/01/03 12:46:25 UTC
[GitHub] spark pull request #16458: [SPARK-19001] [Deploy]don't submit sendHeartbeat ...
GitHub user liujianhuiouc opened a pull request:
https://github.com/apache/spark/pull/16458
[SPARK-19001] [Deploy]don't submit sendHeartbeat task again if has registered
\u2026ed runnable
## What changes were proposed in this pull request?
when first successfully registered response received, set the flag hasRegisteredBefore as true, and when it register next time, it will not submit the SendHeartbeat task again
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liujianhuiouc/spark-1 spark-19001
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16458
----
commit 15f2d3e82e33706c9965822eed027e2411a8b8ed
Author: liujianhui <li...@didichuxing>
Date: 2017-01-03T12:41:17Z
[spark-19001] add a new hasRegisterBefore tag to avoid duplicated fixed runnable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16458: [SPARK-19001] [Deploy]don't submit sendHeartbeat task ag...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16458
We are closing it due to inactivity. please do reopen if you want to push it forward. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16458: [SPARK-19001] [Deploy]don't submit sendHeartbeat task ag...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/16458
Are you still working on this? @liujianhuiouc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16458: [SPARK-19001] [Deploy]don't submit sendHeartbeat ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16458: [SPARK-19001] [Deploy]don't submit sendHeartbeat task ag...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16458
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org