You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ferenc-csaky (via GitHub)" <gi...@apache.org> on 2024/10/15 11:10:32 UTC
[PR] [FLINK-36533] Fix detecting bind failure in case of Netty EPOLL transport [flink]
ferenc-csaky opened a new pull request, #25518:
URL: https://github.com/apache/flink/pull/25518
## What is the purpose of the change
When Netty Epoll transport is enabled, Netty will throw a different bind exception if the given address is already in use. In case of a port range, or multiple ports are given, this will cause process termination after the first non-free port, even if there are more that could be tried.
## Brief change log
Introduce `NettyServer#isBindFailure` method to make bind exception detection more robust. The applied logic takes inspiration from https://github.com/apache/spark/pull/15830.
## Verifying this change
Added unit tests to `NettyServerTest`. I do not assert for `Errors.NativeIoException` because to instantiate such object, it requires proper JNI links, as its ctor always try to call out to native code.
Also verified with a Standalone job on a RedHat8 VM via setting `taskmanager.data.bind-port` to `8081, 55000`, as `8081` will be used by the JobManager anyways, application is able to start correctly with TM on `55000`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36533][runtime] Fix detecting bind failure in case of Netty EPOLL transport [flink]
Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky merged PR #25518:
URL: https://github.com/apache/flink/pull/25518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36533] Fix detecting bind failure in case of Netty EPOLL transport [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25518:
URL: https://github.com/apache/flink/pull/25518#issuecomment-2413601347
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f1fc71d0c5593ad517ce90632276b7bbb85beb54",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f1fc71d0c5593ad517ce90632276b7bbb85beb54",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f1fc71d0c5593ad517ce90632276b7bbb85beb54 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org