[jira] [Comment Edited] (MTOOLCHAINS-31) Not threadsafe for parallel execution

["Ed Randall (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MTOOLCHAINS-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128983#comment-17128983 ] 

Ed Randall edited comment on MTOOLCHAINS-31 at 6/9/20, 8:09 AM:
----------------------------------------------------------------

Note that only maven-toolchains-plugin is of concern here, not the other 2 plugins listed in the description:

 {{07:57:54.243 [BuilderThread 0] [WARNING] *****************************************************************}}
{{ 07:57:54.245 [BuilderThread 0] [WARNING] The following plugins are not marked @threadSafe in your-project-build:}}
{{ 07:57:54.246 [BuilderThread 0] [WARNING] org.apache.maven.plugins:maven-toolchains-plugin:3.0.0}}
{{ 07:57:54.247 [BuilderThread 0] [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.}}
{{ 07:57:54.247 [BuilderThread 0] [WARNING] *****************************************************************}}

 This is a pretty fundamental plugin for any build pipeline in 2020, the warning is quite alarming. 
 We havn't noticed any particular problems around it using --threads so I'm guessing it might even be false.
 It would be really handy if this could be analyzed and addressed in the next release, it might be as simple as adding the {{@threadsafe}} annotation.


was (Author: edrandall):
This is a pretty fundamental plugin for any build pipeline in 2020, the warning is quite alarming.  
We havn't noticed any particular problems around it using --threads so I'm guessing it might even be false.
It would be really handy if this could be analyzed and addressed in the next release, it might be as simple as adding the {{@threadsafe}} annotation.

> Not threadsafe for parallel execution
> -------------------------------------
>
>                 Key: MTOOLCHAINS-31
>                 URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-31
>             Project: Maven Toolchains Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>         Environment: maven 3.6.1
>            Reporter: Hüseyin Kartal
>            Priority: Major
>
> Running maven in parallel mode result in following output which also includes TOOLCHAINS plugin.
> {noformat}
> *****************************************************************
> * Your build is requesting parallel execution, but project      *
> * contains the following plugin(s) that have goals not marked   *
> * as @threadSafe to support parallel building.                  *
> * While this /may/ work fine, please look for plugin updates    *
> * and/or request plugins be made thread-safe.                   *
> * If reporting an issue, report it against the plugin in        *
> * question, not against maven-core                              *
> *****************************************************************
> The following plugins are not marked @threadSafe in Application component: core:
> com.sun.xml.ws:jaxws-maven-plugin:2.3.2
> org.apache.maven.plugins:maven-jxr-plugin:3.0.0
> org.apache.maven.plugins:maven-toolchains-plugin:3.0.0
> Enable debug to see more precisely which goals are not marked @threadSafe.
> *****************************************************************{noformat}
> Toolchains plugin should made and/or marked threadSafe.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)