[jira] [Comment Edited] (KYLIN-999) License check and cleanup for release

["Luke Han (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989751#comment-14989751 ] 

Luke Han edited comment on KYLIN-999 at 11/5/15 1:08 AM:
---------------------------------------------------------

Google fonts have been excluded from the source code, pom and also cleaned up files,
main commit is here:
https://github.com/apache/incubator-kylin/commit/a2fa3e8e93765bf3db39f5da935aca3a588789f1

and will keep license file's content as current one, once merge to other branch especially for 1.x-staging (main dev branch) will remove section about Google and Adobe fonts which added previous.

v1.1.1 already rolled out for vote now.

Will close this ticket once vote pass in IPMC.

Thanks.


was (Author: lukehan):
Google fonts have been excluded from the source code,
updated license file, pom and also cleaned up files.

v1.1.1 already rolled out for vote now.

Will close this ticket once vote pass in IPMC.

Thanks.

> License check and cleanup for release
> -------------------------------------
>
>                 Key: KYLIN-999
>                 URL: https://issues.apache.org/jira/browse/KYLIN-999
>             Project: Kylin
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: v1.1, v1.0
>            Reporter: Luke Han
>            Assignee: Luke Han
>             Fix For: v1.1.1
>
>
> Hi,
> Sorry but it’s -1 (binding), although you have enough +1 to go ahead and make a release.
> This issue that has occurred before [1] and even if the website isn’t included in the release it looks like there may be a still few issues to fix there.
> I checked
> - package contains incubating
> - Signatures good
> - DISCLAIMER exits
> - LICENSE issues (see below)
> - NOTICE fine
> - No unexpected binary files
> - All source file have apache headers
> The file  ./website/assets/css/animate.css has had an Apache header put on it when it is MIT licensed. There are probably other files that are incorrect in this way but I’ve not looked in detail. Perhaps ./website/assets/fonts/helveticaneue-webfont.svg and ./website/assets/fonts/helveticaneue-webfont.css? but that may have a more serious issue.
> The font files ./website/assets/fonts/helveticaneue-webfont.* seem to licensed like so (from the font meta data):
> "Copyright (c) 1988, 1990 Adobe Systems Incorporated.  All Rights Reserved.Helvetica is a registered trademark of Linotype AG and/or its subsidiaries.”
> Other minor LICENSE issues:
> - Missing MIT licensed for animate.css
> - Missing MIT for Bootstrap and normalise.css
> - Missing MIT for jQuery
> - Missing MIT for font awsome
> - Missing SIL for font awsome
> Not required but you may want to add Apache license for the open sans font to LICENSE as it not immediately obvious how that binary file is licensed.
> Thanks,
> Justin
> 1. http://apache.markmail.org/message/z6k3yivyo6xz24by



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)