You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Randy DuCharame <ra...@ad5gb.com.INVALID> on 2020/08/05 14:32:48 UTC
Latest master build broken
Greetings,
Seems the latest commits to master have broken the build. It terminates
with:
..
CXX experimental/memory_profile/memory_profile_la-memory_profile.lo
CXX experimental/metalink/metalink.lo
../../trafficserver/plugins/experimental/maxmind_acl/mmdb.cc:540:6:
error: out-of-line definition of 'eval_ip' does not match any
declaration in 'Acl'
Acl::eval_ip(const sockaddr *sock) const
^~~~~~~
../../trafficserver/plugins/experimental/maxmind_acl/mmdb.h:107:11:
note: member declaration does not match because it is not const qualified
ipstate eval_ip(const sockaddr *sock);
^ ~
CXX experimental/money_trace/money_trace.lo
1 error generated.
make[2]: *** [Makefile:5823: experimental/maxmind_acl/mmdb.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
This seems to make it happy:
diff --git a/plugins/experimental/maxmind_acl/mmdb.h
b/plugins/experimental/maxmind_acl/mmdb.h
index 828ffe3bf..561b42f49 100644
--- a/plugins/experimental/maxmind_acl/mmdb.h
+++ b/plugins/experimental/maxmind_acl/mmdb.h
@@ -104,5 +104,5 @@ protected:
void loadhtml(YAML::Node htmlNode);
bool eval_country(MMDB_entry_data_s *entry_data, const char *path,
int path_len);
void parseregex(YAML::Node regex, bool allow);
- ipstate eval_ip(const sockaddr *sock);
+ ipstate eval_ip(const sockaddr *sock) const;
};
Should I submit another PR or has someone else got this? I didn't see
anything pending in PRs or issues on the hub.
Best!
--
Randall DuCharme (Radio AD5GB)
Powered by Open Source software.
Re: Latest master build broken
Posted by Randy DuCharame <ra...@ad5gb.com.INVALID>.
Ok, Submitted :)
Thanks!
On 8/5/2020 9:32 AM, Randy DuCharame wrote:
> Greetings,
>
> Seems the latest commits to master have broken the build. It terminates
> with:
>
> ..
>
> CXX experimental/memory_profile/memory_profile_la-memory_profile.lo
> CXX experimental/metalink/metalink.lo
> ../../trafficserver/plugins/experimental/maxmind_acl/mmdb.cc:540:6:
> error: out-of-line definition of 'eval_ip' does not match any
> declaration in 'Acl'
> Acl::eval_ip(const sockaddr *sock) const
> ^~~~~~~
> ../../trafficserver/plugins/experimental/maxmind_acl/mmdb.h:107:11:
> note: member declaration does not match because it is not const qualified
> ipstate eval_ip(const sockaddr *sock);
> ^ ~
> CXX experimental/money_trace/money_trace.lo
> 1 error generated.
> make[2]: *** [Makefile:5823: experimental/maxmind_acl/mmdb.lo] Error 1
> make[2]: *** Waiting for unfinished jobs....
>
>
> This seems to make it happy:
>
> diff --git a/plugins/experimental/maxmind_acl/mmdb.h
> b/plugins/experimental/maxmind_acl/mmdb.h
> index 828ffe3bf..561b42f49 100644
> --- a/plugins/experimental/maxmind_acl/mmdb.h
> +++ b/plugins/experimental/maxmind_acl/mmdb.h
> @@ -104,5 +104,5 @@ protected:
> void loadhtml(YAML::Node htmlNode);
> bool eval_country(MMDB_entry_data_s *entry_data, const char *path,
> int path_len);
> void parseregex(YAML::Node regex, bool allow);
> - ipstate eval_ip(const sockaddr *sock);
> + ipstate eval_ip(const sockaddr *sock) const;
> };
>
>
> Should I submit another PR or has someone else got this? I didn't see
> anything pending in PRs or issues on the hub.
>
>
> Best!
>
--
Randall DuCharme (Radio AD5GB)
Powered by Open Source software.
Re: Latest master build broken
Posted by Evan Zelkowitz <ez...@apache.org>.
If you have a pr ready to go then go ahead and submit one. I just
tried it here and saw the same issue and that change fixed it
On Wed, Aug 5, 2020 at 8:51 AM Randy DuCharame <ra...@ad5gb.com.invalid> wrote:
>
> Greetings,
>
> Seems the latest commits to master have broken the build. It terminates
> with:
>
> ..
>
> CXX experimental/memory_profile/memory_profile_la-memory_profile.lo
> CXX experimental/metalink/metalink.lo
> ../../trafficserver/plugins/experimental/maxmind_acl/mmdb.cc:540:6:
> error: out-of-line definition of 'eval_ip' does not match any
> declaration in 'Acl'
> Acl::eval_ip(const sockaddr *sock) const
> ^~~~~~~
> ../../trafficserver/plugins/experimental/maxmind_acl/mmdb.h:107:11:
> note: member declaration does not match because it is not const qualified
> ipstate eval_ip(const sockaddr *sock);
> ^ ~
> CXX experimental/money_trace/money_trace.lo
> 1 error generated.
> make[2]: *** [Makefile:5823: experimental/maxmind_acl/mmdb.lo] Error 1
> make[2]: *** Waiting for unfinished jobs....
>
>
> This seems to make it happy:
>
> diff --git a/plugins/experimental/maxmind_acl/mmdb.h
> b/plugins/experimental/maxmind_acl/mmdb.h
> index 828ffe3bf..561b42f49 100644
> --- a/plugins/experimental/maxmind_acl/mmdb.h
> +++ b/plugins/experimental/maxmind_acl/mmdb.h
> @@ -104,5 +104,5 @@ protected:
> void loadhtml(YAML::Node htmlNode);
> bool eval_country(MMDB_entry_data_s *entry_data, const char *path,
> int path_len);
> void parseregex(YAML::Node regex, bool allow);
> - ipstate eval_ip(const sockaddr *sock);
> + ipstate eval_ip(const sockaddr *sock) const;
> };
>
>
> Should I submit another PR or has someone else got this? I didn't see
> anything pending in PRs or issues on the hub.
>
>
> Best!
>
> --
> Randall DuCharme (Radio AD5GB)
> Powered by Open Source software.
>