You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/14 13:11:42 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
rkhachatryan opened a new pull request #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096
## What is the purpose of the change
*ContinuousFileReaderOperator was changed recently to be created using factory. But some tests create it using constructor directly. This causes problems with deserialization.*
## Brief change log
- *fix test to actually fail on exception - previously error was only logged*
- *use factory in tests*
- *remove testing constructor*
- *make class package-private*
## Verifying this change
This change is already covered by existing tests: `ContinuousFileProcessingITCase`, `ContinuousFileProcessingMigrationTest`, `ContinuousFileProcessingTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149041446 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
* 34ac6e03b86281ba56a4108f0f713f7a769b1291 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149041446) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192)
* 03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#discussion_r380510004
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -70,7 +70,6 @@
import org.apache.flink.streaming.api.datastream.DataStreamSource;
import org.apache.flink.streaming.api.datastream.SingleOutputStreamOperator;
import org.apache.flink.streaming.api.functions.source.ContinuousFileMonitoringFunction;
-import org.apache.flink.streaming.api.functions.source.ContinuousFileReaderOperator;
Review comment:
One more thing. Doesn't removal of line brake the java docs for this class (`@Public` so quite important)?
Replace `{@link ContinuousFileReaderOperator readers}` with full class reference?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski merged pull request #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#discussion_r380526760
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -70,7 +70,6 @@
import org.apache.flink.streaming.api.datastream.DataStreamSource;
import org.apache.flink.streaming.api.datastream.SingleOutputStreamOperator;
import org.apache.flink.streaming.api.functions.source.ContinuousFileMonitoringFunction;
-import org.apache.flink.streaming.api.functions.source.ContinuousFileReaderOperator;
Review comment:
I think a reference to the code might be helpful for some more power users. I would be also fine with referencing `ContinuousFileReaderOperatorFactory` itself, as that wouldn't explode the comment's length.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-587479568
Merged. Can you close the jira ticket @rkhachatryan ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149041446 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
* 34ac6e03b86281ba56a4108f0f713f7a769b1291 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149041446) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149041446 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149280141 TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5248 TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
Hash:1e3e2f44f247790ca4ab7718b005e88708905f1f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149444036 TriggerType:PUSH TriggerID:1e3e2f44f247790ca4ab7718b005e88708905f1f
Hash:1e3e2f44f247790ca4ab7718b005e88708905f1f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5277 TriggerType:PUSH TriggerID:1e3e2f44f247790ca4ab7718b005e88708905f1f
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
* 34ac6e03b86281ba56a4108f0f713f7a769b1291 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149041446) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192)
* 03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149280141) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5248)
* 1e3e2f44f247790ca4ab7718b005e88708905f1f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149444036) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5277)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on a change in pull request #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#discussion_r380623162
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -70,7 +70,6 @@
import org.apache.flink.streaming.api.datastream.DataStreamSource;
import org.apache.flink.streaming.api.datastream.SingleOutputStreamOperator;
import org.apache.flink.streaming.api.functions.source.ContinuousFileMonitoringFunction;
-import org.apache.flink.streaming.api.functions.source.ContinuousFileReaderOperator;
Review comment:
Ok, in that case please update the java docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rkhachatryan commented on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586562655
Thanks for feedback @AHeise,
I've addressed the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rkhachatryan commented on a change in pull request #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#discussion_r380646608
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -70,7 +70,6 @@
import org.apache.flink.streaming.api.datastream.DataStreamSource;
import org.apache.flink.streaming.api.datastream.SingleOutputStreamOperator;
import org.apache.flink.streaming.api.functions.source.ContinuousFileMonitoringFunction;
-import org.apache.flink.streaming.api.functions.source.ContinuousFileReaderOperator;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rkhachatryan commented on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586979181
> LGTM % could you expand the `CFRO` abbreviation in the commit message?
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586282779
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 95adc7d325935a50f3f2c50604cf1f13fe578e18 (Fri Feb 14 13:14:40 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rkhachatryan commented on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-587556454
Done. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rkhachatryan commented on a change in pull request #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#discussion_r380534049
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -70,7 +70,6 @@
import org.apache.flink.streaming.api.datastream.DataStreamSource;
import org.apache.flink.streaming.api.datastream.SingleOutputStreamOperator;
import org.apache.flink.streaming.api.functions.source.ContinuousFileMonitoringFunction;
-import org.apache.flink.streaming.api.functions.source.ContinuousFileReaderOperator;
Review comment:
IMO javadoc of public API shouldn't talk about the implementation classes at all, unless there is a need (here there isn't). And "power users" should be able to go inside the method and see the implementation:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149041446 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149280141 TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5248 TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
Hash:1e3e2f44f247790ca4ab7718b005e88708905f1f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1e3e2f44f247790ca4ab7718b005e88708905f1f
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
* 34ac6e03b86281ba56a4108f0f713f7a769b1291 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149041446) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192)
* 03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149280141) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5248)
* 1e3e2f44f247790ca4ab7718b005e88708905f1f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rkhachatryan commented on a change in pull request #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#discussion_r380519946
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -70,7 +70,6 @@
import org.apache.flink.streaming.api.datastream.DataStreamSource;
import org.apache.flink.streaming.api.datastream.SingleOutputStreamOperator;
import org.apache.flink.streaming.api.functions.source.ContinuousFileMonitoringFunction;
-import org.apache.flink.streaming.api.functions.source.ContinuousFileReaderOperator;
Review comment:
Yes, but the actual operator type is now hidden in the factory, so I'd rather remove the reference at all and leave just plain "readers".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
* 34ac6e03b86281ba56a4108f0f713f7a769b1291 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149041446 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149280141 TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5248 TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
* 34ac6e03b86281ba56a4108f0f713f7a769b1291 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149041446) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192)
* 03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149280141) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5248)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] AHeise commented on a change in pull request #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#discussion_r379471450
##########
File path: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingITCase.java
##########
@@ -140,29 +141,25 @@ public void testProgram() throws Exception {
TestingSinkFunction sink = new TestingSinkFunction();
content.addSink(sink).setParallelism(1);
- Thread job = new Thread() {
-
- @Override
- public void run() {
- try {
- env.execute("ContinuousFileProcessingITCase Job.");
- } catch (Exception e) {
- Throwable th = e;
- for (int depth = 0; depth < 20; depth++) {
- if (th instanceof SuccessException) {
- return;
- } else if (th.getCause() != null) {
- th = th.getCause();
- } else {
- break;
- }
+ CompletableFuture<Void> jobFuture = new CompletableFuture<>();
+ new Thread(() -> {
+ try {
+ env.execute("ContinuousFileProcessingITCase Job.");
+ jobFuture.complete(null);
+ } catch (Exception e) {
+ Throwable th = e;
+ for (int depth = 0; depth < 20; depth++) {
+ if (th instanceof SuccessException) {
+ return;
Review comment:
should that also complete future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149041446 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149280141 TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5248 TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
Hash:1e3e2f44f247790ca4ab7718b005e88708905f1f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149444036 TriggerType:PUSH TriggerID:1e3e2f44f247790ca4ab7718b005e88708905f1f
Hash:1e3e2f44f247790ca4ab7718b005e88708905f1f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5277 TriggerType:PUSH TriggerID:1e3e2f44f247790ca4ab7718b005e88708905f1f
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
* 34ac6e03b86281ba56a4108f0f713f7a769b1291 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149041446) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192)
* 03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149280141) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5248)
* 1e3e2f44f247790ca4ab7718b005e88708905f1f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149444036) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5277)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149041446 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
* 34ac6e03b86281ba56a4108f0f713f7a769b1291 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149041446) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149041446 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149280141 TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
Hash:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5248 TriggerType:PUSH TriggerID:03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
* 34ac6e03b86281ba56a4108f0f713f7a769b1291 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149041446) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192)
* 03ed8e68f6175a3fa9cb86e4ab1e22fe3844b56b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149280141) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5248)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149020890 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:f65641913b8e78475a174d4c45fcf6720324e894 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191 TriggerType:PUSH TriggerID:f65641913b8e78475a174d4c45fcf6720324e894
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149041446 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
Hash:34ac6e03b86281ba56a4108f0f713f7a769b1291 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192 TriggerType:PUSH TriggerID:34ac6e03b86281ba56a4108f0f713f7a769b1291
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
* f65641913b8e78475a174d4c45fcf6720324e894 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149020890) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5191)
* 34ac6e03b86281ba56a4108f0f713f7a769b1291 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149041446) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5192)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11096:
[FLINK-16056][runtime][tests] fix CFRO creation in tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11096: [FLINK-16056][runtime][tests] fix CFRO creation in tests
URL: https://github.com/apache/flink/pull/11096#issuecomment-586300012
<!--
Meta data
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148983706 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
Hash:6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181 TriggerType:PUSH TriggerID:6f1f37ee8baceee6d08b4c4d2439d46f2c144688
-->
## CI report:
* 6f1f37ee8baceee6d08b4c4d2439d46f2c144688 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148983706) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5181)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services