You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/18 05:56:12 UTC
[GitHub] [shardingsphere] dongzl opened a new pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".
dongzl opened a new pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl edited a comment on pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".
Posted by GitBox <gi...@apache.org>.
dongzl edited a comment on pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906#issuecomment-675438574
I communicate with jingshanglu, I will divide different rules for `createIndex` and `insert`. I close this pr and will submit a new pr for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906#issuecomment-675281452
## Pull Request Test Coverage Report for [Build 13869](https://coveralls.io/builds/32822949)
* **0** of **2** **(0.0%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **59.283%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/SQLServerVisitor.java](https://coveralls.io/builds/32822949/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsqlserver%2Fvisitor%2FSQLServerVisitor.java#L228) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/32822949/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsqlserver%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L464) | 0 | 1 | 0.0%
<!-- | **Total:** | **0** | **2** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/32822949) |
| :-- | --: |
| Change from base [Build 13865](https://coveralls.io/builds/32821085): | 0.0% |
| Covered Lines: | 13484 |
| Relevant Lines: | 22745 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on a change in pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".
Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906#discussion_r471967112
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/BaseRule.g4
##########
@@ -119,7 +119,7 @@ name
;
columnNames
- : LP_ columnNameWithSort (COMMA_ columnNameWithSort)* RP_
+ : LP_ columnName (COMMA_ columnName)* RP_
Review comment:
Hi @jingshanglu , `columnNames` also use in the `insertValuesClause`, if use `columnNameWithSort`, I test the `insert into t_order (order_id asc, user_id desc) values (1, 1)` is also a correct sql.
Do we need divide the different rule for `createIndex ` and `insert`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".
Posted by GitBox <gi...@apache.org>.
dongzl commented on pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906#issuecomment-675438574
I communicate with jingshanglu, I will divide different rules for `createIndex` and `insert`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl closed pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".
Posted by GitBox <gi...@apache.org>.
dongzl closed pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906#discussion_r471951187
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/BaseRule.g4
##########
@@ -119,7 +119,7 @@ name
;
columnNames
- : LP_ columnNameWithSort (COMMA_ columnNameWithSort)* RP_
+ : LP_ columnName (COMMA_ columnName)* RP_
Review comment:
@dongzl Maybe it's not appropriate,because `columnNames` is used by `createIndex` in DDLStatement.g4, and actually `columnNameWithSort` is right. url:https://docs.microsoft.com/zh-cn/sql/t-sql/statements/create-index-transact-sql?view=sql-server-ver15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on a change in pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".
Posted by GitBox <gi...@apache.org>.
dongzl commented on a change in pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906#discussion_r471967112
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/BaseRule.g4
##########
@@ -119,7 +119,7 @@ name
;
columnNames
- : LP_ columnNameWithSort (COMMA_ columnNameWithSort)* RP_
+ : LP_ columnName (COMMA_ columnName)* RP_
Review comment:
Hi @jingshanglu , `columnNames` also use in the `insertValuesClause`, if use `columnNameWithSort`, I test the `insert into t_order (order_id asc, user_id desc) values (1, 1)` is also a correct sql.
Do we need to divide the different rules for `createIndex ` and `insert`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #6906: fixes SQLServer SQL “columnNames” parser, instead of “columnNameWithSort".
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #6906:
URL: https://github.com/apache/shardingsphere/pull/6906#discussion_r472028649
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/BaseRule.g4
##########
@@ -119,7 +119,7 @@ name
;
columnNames
- : LP_ columnNameWithSort (COMMA_ columnNameWithSort)* RP_
+ : LP_ columnName (COMMA_ columnName)* RP_
Review comment:
@dongzl It is better to divide rule for `createIndex` and `insert`, because it can ensure the accuracy of grammar, although there is some redundancy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org