You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/07/01 03:35:32 UTC
[GitHub] [cordova-plugin-splashscreen] erisu opened a new pull request, #329: chore: update android engine requirement <11.0.0
erisu opened a new pull request, #329:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/329
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
The Cordova Android platform has inegrated the Splash Screen plugin as core functionality.
This plugin is no longer needed in in the next majpr release of Cordova Android (11.0.0+).
### Description
<!-- Describe your changes in detail -->
Update the engine requirement to not install on 11.0.0 or above.
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on pull request #329: chore: update android engine requirement <11.0.0
Posted by GitBox <gi...@apache.org>.
erisu commented on PR #329:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/329#issuecomment-1172024445
Yes, 7.x will drop all of the Android code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] jcesarmobile commented on pull request #329: chore: update android engine requirement <11.0.0
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on PR #329:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/329#issuecomment-1172023153
Don’t understand the “If using `cordova-android@11.x` or later, use `cordova-plugin-splashscreen@7.x` (currently in-development).”
are we going to launch a 7.x version removing the android code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu merged pull request #329: chore: update android engine requirement <11.0.0
Posted by GitBox <gi...@apache.org>.
erisu merged PR #329:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-splashscreen] erisu commented on pull request #329: chore: update android engine requirement <11.0.0
Posted by GitBox <gi...@apache.org>.
erisu commented on PR #329:
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/329#issuecomment-1172027946
I just kept the wording to match how iOS was written.
It can be reworded as
> If using `cordova-android@11.x` or later and exclusively developing for Android, this plugin can be uninstalled.
This entire section will be deleted in version 7.x anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org