[GitHub] [superset] ktmud edited a comment on pull request #13111: feat: add Echarts Graph chart

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #13111:
URL: https://github.com/apache/superset/pull/13111#issuecomment-779410330


   > > Since the chart type has been renamed, I'm wondering whether we should add a tooltip (or something else) to help old users find the graph chart option:
   > 
   > > 
   > 
   > > <img alt="renamed-chart-type" width="860" src="https://user-images.githubusercontent.com/335541/107873798-1736fb00-6e6a-11eb-94b3-ef4f2893e67a.png">
   > 
   > > 
   > 
   > > But I'm sure people will eventually find it even without this tooltip.
   > 
   > 
   > 
   > Cool,how to do it?
   > 
   > Migration to put notification some table?
   > 
   > @ktmud 
   
   The tooltip is just a suggestion. We can hard-code a closable one-time tooltip if we want to implement it. It should satisfy following requirements:
   
   1. Only showing it once for users who have not viewed it.
   2. Remember the viewed status in cookie or localStorage
   3. The tooltip is open by default and the viewed status will only be updated when it is scrolled into viewport.
   
   
   If this is too much work, feel free to wait for the gallery modal redesign work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org