You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/08 08:51:32 UTC

[GitHub] [rocketmq] echooymxq commented on issue #5209: Should truncate the commitLog base on confirmOffset?

echooymxq commented on issue #5209:
URL: https://github.com/apache/rocketmq/issues/5209#issuecomment-1272270035

   @lizhimins @RongtongJin  Controller模式下应该不太涉及到日志状态机，我提出的疑问是：当前的代码实现，分发领先(dispatchBehind)是用confirmOffset减reputFromOffset，在切换时如果不先把confirmOffset重置到maxOffset，比如reputFromOffset=confirmOffset < maxOffset时，那truncateInvalidMsg相当于有问题了，我的理解在truncateInvalidMsg前后都应该计算一下confirmOffset。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org