You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/17 05:05:39 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3945: [ISSUE #3944]Var of type SpanProcessor no need to be defined as global variables in ZipkinTraceService, PinpointTraceService
pandaapo opened a new pull request, #3945:
URL: https://github.com/apache/eventmesh/pull/3945
Fixes #3944.
### Motivation
See "" in [issue](https://github.com/apache/eventmesh/issues/3944#issue-1712971113).
### Modifications
See "" in [issue](https://github.com/apache/eventmesh/issues/3944#issue-1712971113).
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3945: [ISSUE #3944]Var of type SpanProcessor no need to be defined as global variables in ZipkinTraceService, PinpointTraceService
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3945:
URL: https://github.com/apache/eventmesh/pull/3945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3945: [ISSUE #3944]Var of type SpanProcessor no need to be defined as global variables in ZipkinTraceService, PinpointTraceService
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3945:
URL: https://github.com/apache/eventmesh/pull/3945#issuecomment-1556724511
About this part of the error in CI
```
Execution failed for task ':eventmesh-common:checkstyleMain'.
> A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction
> An unexpected error occurred configuring and executing Checkstyle.
> Unable to create Root Module: config {/home/runner/work/eventmesh/eventmesh/style/checkStyle.xml}, classpath {null}.
```
you can try to review this pr #4000 by the way (if you are free and feel necessary). This pr can get the checkstyle failure report instead of exception like above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3945: [ISSUE #3944]Var of type SpanProcessor no need to be defined as global variables in ZipkinTraceService, PinpointTraceService
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3945:
URL: https://github.com/apache/eventmesh/pull/3945#issuecomment-1566384601
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3945](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9843051) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/0ce8d57e6a87890354fdc0643f06aae4acb6cc41?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0ce8d57) will **decrease** coverage by `0.17%`.
> The diff coverage is `10.95%`.
> :exclamation: Current head 9843051 differs from pull request most recent head 4c4999d. Consider uploading reports for the commit 4c4999d to get more accurate results
```diff
@@ Coverage Diff @@
## master #3945 +/- ##
============================================
- Coverage 14.24% 14.07% -0.17%
+ Complexity 1320 1310 -10
============================================
Files 579 580 +1
Lines 28967 28887 -80
Branches 2802 2789 -13
============================================
- Hits 4125 4067 -58
+ Misses 24450 24434 -16
+ Partials 392 386 -6
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../apache/eventmesh/common/config/ConfigService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlnU2VydmljZS5qYXZh) | `41.37% <0.00%> (-3.07%)` | :arrow_down: |
| [...col/http/body/message/PushMessageResponseBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9QdXNoTWVzc2FnZVJlc3BvbnNlQm9keS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ol/http/body/message/ReplyMessageResponseBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9SZXBseU1lc3NhZ2VSZXNwb25zZUJvZHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ttp/body/message/SendMessageBatchResponseBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9TZW5kTWVzc2FnZUJhdGNoUmVzcG9uc2VCb2R5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...p/body/message/SendMessageBatchV2ResponseBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9TZW5kTWVzc2FnZUJhdGNoVjJSZXNwb25zZUJvZHkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...col/http/body/message/SendMessageResponseBody.java](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvbWVzc2FnZS9TZW5kTWVzc2FnZVJlc3BvbnNlQm9keS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/eventmesh/common/utils/ReflectUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9SZWZsZWN0VXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ache/eventmesh/trace/api/AbstractTraceService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2UvYXBpL0Fic3RyYWN0VHJhY2VTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...mesh/trace/api/common/EventMeshTraceConstants.java](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvdHJhY2UvYXBpL2NvbW1vbi9FdmVudE1lc2hUcmFjZUNvbnN0YW50cy5qYXZh) | `0.00% <ø> (ø)` | |
| [...tmesh/trace/pinpoint/common/PinpointConstants.java](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXRyYWNlLXBsdWdpbi9ldmVudG1lc2gtdHJhY2UtcGlucG9pbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC90cmFjZS9waW5wb2ludC9jb21tb24vUGlucG9pbnRDb25zdGFudHMuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [5 more](https://app.codecov.io/gh/apache/eventmesh/pull/3945?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3945/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 commented on pull request #3945: [ISSUE #3944]Var of type SpanProcessor no need to be defined as global variables in ZipkinTraceService, PinpointTraceService
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #3945:
URL: https://github.com/apache/eventmesh/pull/3945#issuecomment-1556462833
@pandaapo please fix the ci check error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3945: [ISSUE #3944]Var of type SpanProcessor no need to be defined as global variables in ZipkinTraceService, PinpointTraceService
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3945:
URL: https://github.com/apache/eventmesh/pull/3945#issuecomment-1556604404
> @pandaapo please fix the ci check error
Fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org