You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/02 09:09:00 UTC

[GitHub] [airflow] potiuk commented on issue #27929: AIP-51 - Single Threaded Executors

potiuk commented on issue #27929:
URL: https://github.com/apache/airflow/issues/27929#issuecomment-1368760769

   Yes. Unfortunately we have this circular behaviour. Which I hate personally.
   
   I am not sure, maybe that could be a good time to start decoupling this as well. I believe we should be able to do it by extracting this as well? 
   
   However EVERY SINGLE TIME I tried to do it (I tried possibly three times already) things look easy to begin with but after enough number of refactoring you end up with some unsolvable entanglement in both directions. And eventually I abandoned the idea each time because there were more pressing things to do.
   
   But I think we can solve it by applying a reasonable split between modules and possibly very little code duplication because we are trying to use generic conf in settings and settings in conf and this is very bad decision in general - we should extract some common code use in both conf and setting to a separate module and use it from both places (but it's not super easy and it will lead to likely many changes and some potential  back-compat issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org