You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by cd...@apache.org on 2016/10/21 15:17:17 UTC

[39/44] git commit: [flex-falcon] [refs/heads/feature-autobuild/maven-archetypes] - ParameterEmitter: fixed issue where this wasn't called due to an old override

ParameterEmitter: fixed issue where this wasn't called due to an old override


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/626b617c
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/626b617c
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/626b617c

Branch: refs/heads/feature-autobuild/maven-archetypes
Commit: 626b617cfb20d4c073775090ca7500d39eb32f48
Parents: 47cf23c
Author: Josh Tynjala <jo...@gmail.com>
Authored: Mon Oct 17 14:01:37 2016 -0700
Committer: Josh Tynjala <jo...@gmail.com>
Committed: Mon Oct 17 14:01:37 2016 -0700

----------------------------------------------------------------------
 .../internal/codegen/js/goog/JSGoogEmitter.java |  6 ------
 .../codegen/js/jx/ParameterEmitter.java         | 21 +-------------------
 2 files changed, 1 insertion(+), 26 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/626b617c/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
index a4cbefc..b0af5b1 100644
--- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
+++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
@@ -887,12 +887,6 @@ public class JSGoogEmitter extends JSEmitter implements IJSGoogEmitter
     }
 
     @Override
-    public void emitParameter(IParameterNode node)
-    {
-        getWalker().walk(node.getNameExpressionNode());
-    }
-
-    @Override
     public void emitAssignedValue(IExpressionNode node)
     {
         if (node == null)

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/626b617c/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/ParameterEmitter.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/ParameterEmitter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/ParameterEmitter.java
index 832d691..e04e4ff 100644
--- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/ParameterEmitter.java
+++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/ParameterEmitter.java
@@ -37,25 +37,6 @@ public class ParameterEmitter extends JSSubEmitter implements
     @Override
     public void emit(IParameterNode node)
     {
-        startMapping(node);
-        if (node.isRest())
-        {
-            write(ASEmitterTokens.ELLIPSIS);
-            write(node.getName());
-        }
-        else
-        {
-            getWalker().walk(node.getNameExpressionNode());
-            write(ASEmitterTokens.COLON);
-            getWalker().walk(node.getVariableTypeNode());
-            IExpressionNode anode = node.getAssignedValueNode();
-            if (anode != null)
-            {
-                write(ASEmitterTokens.SPACE);
-                writeToken(ASEmitterTokens.EQUAL);
-                getWalker().walk(anode);
-            }
-        }
-        endMapping(node);
+        getWalker().walk(node.getNameExpressionNode());
     }
 }