You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Eric Olander <ol...@gmail.com> on 2015/01/13 04:47:15 UTC

Review Request 29840: Patch for KAFKA-1818

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29840/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1818
    https://issues.apache.org/jira/browse/KAFKA-1818


Repository: kafka


Description
-------

KAFKA-1818 clean up code to more idiomatic scala usage


Diffs
-----

  core/src/main/scala/kafka/utils/ReplicationUtils.scala 715767380f7c284148689fd34d4bfba51abd96a0 
  core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala 84e08557de5acdcf0a98b192feac72836ea359b8 

Diff: https://reviews.apache.org/r/29840/diff/


Testing
-------


Thanks,

Eric Olander


Re: Review Request 29840: Patch for KAFKA-1818

Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29840/#review68549
-----------------------------------------------------------

Ship it!


Looks nice, thanks for the cleanup and the test.

non-binding +1 from me.

- Gwen Shapira


On Jan. 17, 2015, 3:32 p.m., Eric Olander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29840/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 3:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1818
>     https://issues.apache.org/jira/browse/KAFKA-1818
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1818 clean up code to more idiomatic scala usage
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/utils/ReplicationUtils.scala 715767380f7c284148689fd34d4bfba51abd96a0 
>   core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala 84e08557de5acdcf0a98b192feac72836ea359b8 
> 
> Diff: https://reviews.apache.org/r/29840/diff/
> 
> 
> Testing
> -------
> 
> This patch replaces some pattern matching on Option with calls to flatMap.  Unit test added to cover both possible return values from ReplicationUtils.getLeaderIsrAndEpochForPartition.
> 
> 
> Thanks,
> 
> Eric Olander
> 
>


Re: Review Request 29840: Patch for KAFKA-1818

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29840/#review69580
-----------------------------------------------------------



core/src/main/scala/kafka/utils/ReplicationUtils.scala
<https://reviews.apache.org/r/29840/#comment114288>

    minor formatting nit: Need to include a space after flatMap


- Neha Narkhede


On Jan. 17, 2015, 3:32 p.m., Eric Olander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29840/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 3:32 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1818
>     https://issues.apache.org/jira/browse/KAFKA-1818
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1818 clean up code to more idiomatic scala usage
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/utils/ReplicationUtils.scala 715767380f7c284148689fd34d4bfba51abd96a0 
>   core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala 84e08557de5acdcf0a98b192feac72836ea359b8 
> 
> Diff: https://reviews.apache.org/r/29840/diff/
> 
> 
> Testing
> -------
> 
> This patch replaces some pattern matching on Option with calls to flatMap.  Unit test added to cover both possible return values from ReplicationUtils.getLeaderIsrAndEpochForPartition.
> 
> 
> Thanks,
> 
> Eric Olander
> 
>


Re: Review Request 29840: Patch for KAFKA-1818

Posted by Eric Olander <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29840/
-----------------------------------------------------------

(Updated Jan. 17, 2015, 3:32 p.m.)


Review request for kafka.


Bugs: KAFKA-1818
    https://issues.apache.org/jira/browse/KAFKA-1818


Repository: kafka


Description
-------

KAFKA-1818 clean up code to more idiomatic scala usage


Diffs
-----

  core/src/main/scala/kafka/utils/ReplicationUtils.scala 715767380f7c284148689fd34d4bfba51abd96a0 
  core/src/test/scala/unit/kafka/utils/ReplicationUtilsTest.scala 84e08557de5acdcf0a98b192feac72836ea359b8 

Diff: https://reviews.apache.org/r/29840/diff/


Testing (updated)
-------

This patch replaces some pattern matching on Option with calls to flatMap.  Unit test added to cover both possible return values from ReplicationUtils.getLeaderIsrAndEpochForPartition.


Thanks,

Eric Olander