You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/11 13:29:39 UTC
[GitHub] [superset] kgabryje opened a new pull request, #20668: feat: Reuse Dashboard redux data in Explore
kgabryje opened a new pull request, #20668:
URL: https://github.com/apache/superset/pull/20668
### SUMMARY
Currently when user open Explore, we always send a request to `/v1/explore` endpoint, which assembles Explore initial data - slice, form_data and datasource.
When user goes to Explore from Dashboard (by clicking "Edit chart" or char title), most of the data needed to assemble Explore should already be available in Redux store.
This PR implements using data from Dashboard Redux store to initialize Explore without calling `/v1/explore` endpoint.
If user opens Explore from Dashboard, check if slice, formData, datasourceId and datasourceType are available. If they are, fetch datasource metadata and hydrate Explore using slice, formData and datasource.
If they are not available, call `/v1/explore` and hydrate Explore.
We can't reuse datasource from Dashboard. Datasources metadata on Dashboard is trimmed so that datasource contains only columns and metrics used by charts on that dashboard. In Explore we need to be able to access all columns and metrics, which means we must fetch those from API.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
1. Go to dashboard
2. Click "Edit chart"
3. Verify that Explore has opened correctly and that we did not call `/v1/explore/` endpoint
4. Enter Explore from any other entry point (for example Charts list or Welcome page)
5. Verify that we do call `/v1/explore`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #20668:
URL: https://github.com/apache/superset/pull/20668#issuecomment-1182260021
This PR will be re-opened when linking from Dashboard to Explore is refactored (coming in a few days)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #20668:
URL: https://github.com/apache/superset/pull/20668#discussion_r918706849
##########
superset-frontend/src/explore/ExplorePage.tsx:
##########
@@ -38,12 +45,58 @@ const fetchExploreData = () => {
})(exploreUrlParams);
};
+const useExploreInitialData = (
+ shouldUseDashboardData: boolean,
+ sliceId: string | null,
+) => {
+ const slice = useSelector<RootState, Slice | null>(({ sliceEntities }) =>
+ isDefined(sliceId) ? sliceEntities?.slices?.[sliceId] : null,
+ );
+ const formData = slice?.form_data;
+ const { id: datasourceId, type: datasourceType } = useSelector<
+ RootState,
+ { id: number | undefined; type: string | undefined }
+ >(({ datasources }) =>
+ formData?.datasource
+ ? pick(datasources[formData.datasource], ['id', 'type'])
+ : { id: undefined, type: undefined },
+ );
+ return useCallback(() => {
+ if (
+ !shouldUseDashboardData ||
+ !isDefined(slice) ||
+ !isDefined(formData) ||
+ !isDefined(datasourceId) ||
+ !isDefined(datasourceType)
+ ) {
+ return fetchExploreData();
+ }
+ return SupersetClient.get({
+ endpoint: `/datasource/get/${datasourceType}/${datasourceId}/`,
Review Comment:
I propose we stick to the legacy `/datasource/get` endpoint for now and create a new `/v1/datasource` API in the future and refactor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #20668:
URL: https://github.com/apache/superset/pull/20668#discussion_r918600221
##########
superset-frontend/src/explore/ExplorePage.tsx:
##########
@@ -38,12 +45,58 @@ const fetchExploreData = () => {
})(exploreUrlParams);
};
+const useExploreInitialData = (
+ shouldUseDashboardData: boolean,
+ sliceId: string | null,
+) => {
+ const slice = useSelector<RootState, Slice | null>(({ sliceEntities }) =>
+ isDefined(sliceId) ? sliceEntities?.slices?.[sliceId] : null,
+ );
+ const formData = slice?.form_data;
+ const { id: datasourceId, type: datasourceType } = useSelector<
+ RootState,
+ { id: number | undefined; type: string | undefined }
+ >(({ datasources }) =>
+ formData?.datasource
+ ? pick(datasources[formData.datasource], ['id', 'type'])
+ : { id: undefined, type: undefined },
+ );
+ return useCallback(() => {
+ if (
+ !shouldUseDashboardData ||
+ !isDefined(slice) ||
+ !isDefined(formData) ||
+ !isDefined(datasourceId) ||
+ !isDefined(datasourceType)
+ ) {
+ return fetchExploreData();
+ }
+ return SupersetClient.get({
+ endpoint: `/datasource/get/${datasourceType}/${datasourceId}/`,
Review Comment:
there is a new endpoint for the dataset GET method is `/api/v1/dataset/<datasource PK(a.k.a datasource id without type>`. I added it at [here](https://github.com/apache/superset/pull/20677/files#diff-cc681838b8b8b6cb3d1a5dbf02c118d5f3353db8023f49c55f7a673e879be030)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
kgabryje commented on PR #20668:
URL: https://github.com/apache/superset/pull/20668#issuecomment-1181745594
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #20668:
URL: https://github.com/apache/superset/pull/20668#issuecomment-1180602947
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20668:
URL: https://github.com/apache/superset/pull/20668#issuecomment-1181746895
@kgabryje Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #20668:
URL: https://github.com/apache/superset/pull/20668#discussion_r919067527
##########
superset-frontend/src/explore/ExplorePage.tsx:
##########
@@ -38,12 +45,58 @@ const fetchExploreData = () => {
})(exploreUrlParams);
};
+const useExploreInitialData = (
+ shouldUseDashboardData: boolean,
+ sliceId: string | null,
+) => {
+ const slice = useSelector<RootState, Slice | null>(({ sliceEntities }) =>
+ isDefined(sliceId) ? sliceEntities?.slices?.[sliceId] : null,
+ );
+ const formData = slice?.form_data;
+ const { id: datasourceId, type: datasourceType } = useSelector<
+ RootState,
+ { id: number | undefined; type: string | undefined }
+ >(({ datasources }) =>
+ formData?.datasource
+ ? pick(datasources[formData.datasource], ['id', 'type'])
+ : { id: undefined, type: undefined },
+ );
+ return useCallback(() => {
+ if (
+ !shouldUseDashboardData ||
+ !isDefined(slice) ||
+ !isDefined(formData) ||
+ !isDefined(datasourceId) ||
+ !isDefined(datasourceType)
+ ) {
+ return fetchExploreData();
+ }
+ return SupersetClient.get({
+ endpoint: `/datasource/get/${datasourceType}/${datasourceId}/`,
Review Comment:
@kgabryje Thanks for the explanation, we will optimize it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a diff in pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
kgabryje commented on code in PR #20668:
URL: https://github.com/apache/superset/pull/20668#discussion_r918705759
##########
superset-frontend/src/explore/ExplorePage.tsx:
##########
@@ -38,12 +45,58 @@ const fetchExploreData = () => {
})(exploreUrlParams);
};
+const useExploreInitialData = (
+ shouldUseDashboardData: boolean,
+ sliceId: string | null,
+) => {
+ const slice = useSelector<RootState, Slice | null>(({ sliceEntities }) =>
+ isDefined(sliceId) ? sliceEntities?.slices?.[sliceId] : null,
+ );
+ const formData = slice?.form_data;
+ const { id: datasourceId, type: datasourceType } = useSelector<
+ RootState,
+ { id: number | undefined; type: string | undefined }
+ >(({ datasources }) =>
+ formData?.datasource
+ ? pick(datasources[formData.datasource], ['id', 'type'])
+ : { id: undefined, type: undefined },
+ );
+ return useCallback(() => {
+ if (
+ !shouldUseDashboardData ||
+ !isDefined(slice) ||
+ !isDefined(formData) ||
+ !isDefined(datasourceId) ||
+ !isDefined(datasourceType)
+ ) {
+ return fetchExploreData();
+ }
+ return SupersetClient.get({
+ endpoint: `/datasource/get/${datasourceType}/${datasourceId}/`,
Review Comment:
I actually used `GET /v1/dataset` endpoint at first, but then changed it to `GET /datasource/get/`. As far as I know, Explore now supports (or will soon support?) other sources than datasets, such as SQL queries. Tagging @hughhhh for transparency.
Also, the `/v1/explore/` endpoint uses `DatasourceDAO` to get datasource and the response from `/v1/dataset` endpoint is missing some fields compared to datasource from `/v1/explore`, which caused some components in Explore to crash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20668:
URL: https://github.com/apache/superset/pull/20668#issuecomment-1180431251
# [Codecov](https://codecov.io/gh/apache/superset/pull/20668?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20668](https://codecov.io/gh/apache/superset/pull/20668?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d85d3bb) into [master](https://codecov.io/gh/apache/superset/commit/c29261b63dee723f108b3404e29a498ecf8421f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c29261b) will **decrease** coverage by `11.82%`.
> The diff coverage is `31.81%`.
> :exclamation: Current head d85d3bb differs from pull request most recent head 6bb360e. Consider uploading reports for the commit 6bb360e to get more accurate results
```diff
@@ Coverage Diff @@
## master #20668 +/- ##
===========================================
- Coverage 66.85% 55.02% -11.83%
===========================================
Files 1753 1753
Lines 65823 65829 +6
Branches 7007 7007
===========================================
- Hits 44005 36224 -7781
- Misses 20032 27819 +7787
Partials 1786 1786
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.74% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `58.35% <100.00%> (-24.63%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `50.96% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20668?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/packages/superset-ui-core/src/utils/isDefined.ts](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvaXNEZWZpbmVkLnRz) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/dashboard/actions/hydrate.js](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2h5ZHJhdGUuanM=) | `2.06% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `56.60% <0.00%> (ø)` | |
| [superset-frontend/src/explore/ExplorePage.tsx](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvRXhwbG9yZVBhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [...set-frontend/src/explore/actions/hydrateExplore.ts](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9oeWRyYXRlRXhwbG9yZS50cw==) | `60.00% <100.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `99.36% <100.00%> (+0.01%)` | :arrow_up: |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/key\_value/commands/upsert.py](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3Vwc2VydC5weQ==) | `0.00% <0.00%> (-89.14%)` | :arrow_down: |
| [superset/key\_value/commands/update.py](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
| [superset/key\_value/commands/delete.py](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `0.00% <0.00%> (-85.30%)` | :arrow_down: |
| ... and [284 more](https://codecov.io/gh/apache/superset/pull/20668/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20668?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20668?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c29261b...6bb360e](https://codecov.io/gh/apache/superset/pull/20668?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20668:
URL: https://github.com/apache/superset/pull/20668#issuecomment-1180647443
@zhaoyongjie Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20668:
URL: https://github.com/apache/superset/pull/20668#issuecomment-1180647451
@zhaoyongjie Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20668:
URL: https://github.com/apache/superset/pull/20668#issuecomment-1181746918
@kgabryje Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #20668: feat: Reuse Dashboard redux data in Explore
Posted by GitBox <gi...@apache.org>.
kgabryje merged PR #20668:
URL: https://github.com/apache/superset/pull/20668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org