You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/15 22:51:18 UTC
[GitHub] [spark] viirya opened a new pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
viirya opened a new pull request #30381:
URL: https://github.com/apache/spark/pull/30381
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch proposes to add end-to-end test for subexpression elimination.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We have subexpression elimination feature for expression evaluation but we don't have end-to-end tests for the feature. We should have one to make sure we don't break it.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, dev only.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30381:
URL: https://github.com/apache/spark/pull/30381#discussion_r523932172
##########
File path: sql/core/src/test/resources/sql-tests/inputs/subexp-elimination.sql
##########
@@ -0,0 +1,37 @@
+-- Test for subexpression elimination.
+
+--SET spark.sql.optimizer.enableJsonExpressionOptimization=false
+
+--CONFIG_DIM1 spark.sql.codegen.wholeStage=true
+--CONFIG_DIM1 spark.sql.codegen.wholeStage=false
+
+--CONFIG_DIM2 spark.sql.codegen.factoryMode=CODEGEN_ONLY
+--CONFIG_DIM2 spark.sql.codegen.factoryMode=NO_CODEGEN
+
+--CONFIG_DIM3 SUBEXPRESSION_ELIMINATION_ENABLED=true
+--CONFIG_DIM3 SUBEXPRESSION_ELIMINATION_ENABLED=false
Review comment:
Fix in #30384.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30381:
URL: https://github.com/apache/spark/pull/30381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727711807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727661034
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35716/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-728559747
Thanks for adding it, @viirya !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727711121
**[Test build #131113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131113/testReport)** for PR 30381 at commit [`bed31bf`](https://github.com/apache/spark/commit/bed31bf6fedea9add57caf72448c4b9f5bd12f70).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30381:
URL: https://github.com/apache/spark/pull/30381#discussion_r523929310
##########
File path: sql/core/src/test/resources/sql-tests/inputs/subexp-elimination.sql
##########
@@ -0,0 +1,37 @@
+-- Test for subexpression elimination.
+
+--SET spark.sql.optimizer.enableJsonExpressionOptimization=false
+
+--CONFIG_DIM1 spark.sql.codegen.wholeStage=true
+--CONFIG_DIM1 spark.sql.codegen.wholeStage=false
+
+--CONFIG_DIM2 spark.sql.codegen.factoryMode=CODEGEN_ONLY
+--CONFIG_DIM2 spark.sql.codegen.factoryMode=NO_CODEGEN
+
+--CONFIG_DIM3 SUBEXPRESSION_ELIMINATION_ENABLED=true
Review comment:
is `SUBEXPRESSION_ELIMINATION_ENABLED` a config name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30381:
URL: https://github.com/apache/spark/pull/30381#discussion_r523929393
##########
File path: sql/core/src/test/resources/sql-tests/inputs/subexp-elimination.sql
##########
@@ -0,0 +1,37 @@
+-- Test for subexpression elimination.
+
+--SET spark.sql.optimizer.enableJsonExpressionOptimization=false
+
+--CONFIG_DIM1 spark.sql.codegen.wholeStage=true
+--CONFIG_DIM1 spark.sql.codegen.wholeStage=false
+
+--CONFIG_DIM2 spark.sql.codegen.factoryMode=CODEGEN_ONLY
+--CONFIG_DIM2 spark.sql.codegen.factoryMode=NO_CODEGEN
+
+--CONFIG_DIM3 SUBEXPRESSION_ELIMINATION_ENABLED=true
+--CONFIG_DIM3 SUBEXPRESSION_ELIMINATION_ENABLED=false
Review comment:
Oops, let me fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727773690
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727661047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727653513
Thank you for pinging me, @viirya .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727661047
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30381:
URL: https://github.com/apache/spark/pull/30381#discussion_r523929112
##########
File path: sql/core/src/test/resources/sql-tests/inputs/subexp-elimination.sql
##########
@@ -0,0 +1,37 @@
+-- Test for subexpression elimination.
+
+--SET spark.sql.optimizer.enableJsonExpressionOptimization=false
+
+--CONFIG_DIM1 spark.sql.codegen.wholeStage=true
+--CONFIG_DIM1 spark.sql.codegen.wholeStage=false
+
+--CONFIG_DIM2 spark.sql.codegen.factoryMode=CODEGEN_ONLY
+--CONFIG_DIM2 spark.sql.codegen.factoryMode=NO_CODEGEN
+
+--CONFIG_DIM3 SUBEXPRESSION_ELIMINATION_ENABLED=true
+--CONFIG_DIM3 SUBEXPRESSION_ELIMINATION_ENABLED=false
Review comment:
Wait, shouldn't it be the actual config names?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727651346
cc @dongjoon-hyun @maropu @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727658111
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35716/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727711807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727652255
**[Test build #131113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131113/testReport)** for PR 30381 at commit [`bed31bf`](https://github.com/apache/spark/commit/bed31bf6fedea9add57caf72448c4b9f5bd12f70).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727774217
Thanks @HyukjinKwon @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30381: [SPARK-33456][SQL][TEST] Add end-to-end test for subexpression elimination
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30381:
URL: https://github.com/apache/spark/pull/30381#issuecomment-727652255
**[Test build #131113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131113/testReport)** for PR 30381 at commit [`bed31bf`](https://github.com/apache/spark/commit/bed31bf6fedea9add57caf72448c4b9f5bd12f70).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org