You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Lars Francke (JIRA)" <ji...@apache.org> on 2012/05/18 16:23:07 UTC
[jira] [Created] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Lars Francke created OOZIE-846:
----------------------------------
Summary: OozieClient iterates over Properties using Hashtable method
Key: OOZIE-846
URL: https://issues.apache.org/jira/browse/OOZIE-846
Project: Oozie
Issue Type: Bug
Components: client
Affects Versions: 3.2.0
Reporter: Lars Francke
Priority: Minor
OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
{code}
for (Enumeration e = props.keys(); e.hasMoreElements();) {
{code}
{{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396234#comment-13396234 ]
Alejandro Abdelnur commented on OOZIE-846:
------------------------------------------
@Lars, your 'clean' patch seems empty, would you mind re-uploading it? Also, it would be great adding a testcase to verify the patch does fix the issue. thx
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Labels: patch
> Attachments: OOZIE-846.2.clean.patch, OOZIE-846.2.patch, OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated OOZIE-846:
-------------------------------
Attachment: (was: OOZIE-846.2.clean.patch)
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Labels: patch
> Attachments: OOZIE-846.2.patch, OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398846#comment-13398846 ]
Alejandro Abdelnur commented on OOZIE-846:
------------------------------------------
+1, run the TestOozieCLI testcase to ensure no regressions. As per JDK docs it should do the right thing.
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Labels: patch
> Fix For: trunk
>
> Attachments: OOZIE-846.2.clean.patch, OOZIE-846.2.patch, OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated OOZIE-846:
-------------------------------
Attachment: OOZIE-846.2.clean.patch
Reattach clean patch - this does not include a test.
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Labels: patch
> Attachments: OOZIE-846.2.clean.patch, OOZIE-846.2.patch, OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Seetharam Venkatesh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Seetharam Venkatesh updated OOZIE-846:
--------------------------------------
Attachment: OOZIE-846.patch
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Priority: Minor
> Labels: patch
> Attachments: OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Francke updated OOZIE-846:
-------------------------------
Attachment: OOZIE-846.2.clean.patch
OOZIE-846.2.patch
I didn't get to it earlier. Thank you Seetharam for jumping in.
I've attached another patch building on the earlier one that also changes {{get()}} to {{getProperty()}}.
I've attached two versions: One with the additional changes from the first patch and one that's only concerned with the changes from this issue.
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Labels: patch
> Attachments: OOZIE-846.2.clean.patch, OOZIE-846.2.patch, OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397706#comment-13397706 ]
Alejandro Abdelnur commented on OOZIE-846:
------------------------------------------
@Lars, @Venkatesh, any update on this?
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Labels: patch
> Attachments: OOZIE-846.2.clean.patch, OOZIE-846.2.patch, OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278989#comment-13278989 ]
Alejandro Abdelnur commented on OOZIE-846:
------------------------------------------
@Lars, good find, I guess this hits people using the Java API. Would you mind uploading a patch?
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: 3.2.0
> Reporter: Lars Francke
> Priority: Minor
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398852#comment-13398852 ]
Lars Francke commented on OOZIE-846:
------------------------------------
Yeah sorry I couldn't figure out a quick and easy way to test the method in question. Thanks!
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Labels: patch
> Fix For: trunk
>
> Attachments: OOZIE-846.2.clean.patch, OOZIE-846.2.patch, OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Lars Francke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397721#comment-13397721 ]
Lars Francke commented on OOZIE-846:
------------------------------------
Sorry, forgot to reply.
I'll try to get to it tomorrow. Don't know happened with the upload. I'll look into adding a test too.
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Labels: patch
> Attachments: OOZIE-846.2.clean.patch, OOZIE-846.2.patch, OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur reassigned OOZIE-846:
----------------------------------------
Assignee: Seetharam Venkatesh
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Labels: patch
> Attachments: OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OOZIE-846) OozieClient iterates over Properties
using Hashtable method
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur reassigned OOZIE-846:
----------------------------------------
Assignee: Lars Francke (was: Seetharam Venkatesh)
re-assigning it to Lars (just added him as contributor)
> OozieClient iterates over Properties using Hashtable method
> -----------------------------------------------------------
>
> Key: OOZIE-846
> URL: https://issues.apache.org/jira/browse/OOZIE-846
> Project: Oozie
> Issue Type: Bug
> Components: client
> Affects Versions: trunk
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Labels: patch
> Attachments: OOZIE-846.2.clean.patch, OOZIE-846.2.patch, OOZIE-846.patch
>
>
> OozieClient uses this code to enumerate over a passed in Properties object to convert it to XML:
> {code}
> for (Enumeration e = props.keys(); e.hasMoreElements();) {
> {code}
> {{keys()}} is a method from {{Hashtable}} and misses the _defaults_ that can be used with {{Properties}}. {{Properties.propertyNames()}} should be used instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira