You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/18 00:13:03 UTC
[GitHub] [tvm] Raghav-Chakravarthy opened a new pull request #9040: [Code Style Change] Changed code to match the tvm code style conventions.
Raghav-Chakravarthy opened a new pull request #9040:
URL: https://github.com/apache/tvm/pull/9040
[Issue]
While reviewing the tvm code, I noticed some naming convention issues
in the diag_ctx_ and current_func variables.
Variable current_func should be current_func_ because it is a class
variable
Variable diag_ctx_ should be diag_ctx , because it is a public variable
[Solution]
Changed the variables to match the tvm code style conventions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #9040: [Code Style] Changed code to match the tvm code style conventions.
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #9040:
URL: https://github.com/apache/tvm/pull/9040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Raghav-Chakravarthy commented on pull request #9040: [Code Style] Changed code to match the tvm code style conventions.
Posted by GitBox <gi...@apache.org>.
Raghav-Chakravarthy commented on pull request #9040:
URL: https://github.com/apache/tvm/pull/9040#issuecomment-949899771
@areusch @mbrookhart - Please take a look at my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #9040: [Code Style] Changed code to match the tvm code style conventions.
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9040:
URL: https://github.com/apache/tvm/pull/9040#issuecomment-943492288
@Raghav-Chakravarthy please fix the lint error when you get a minute!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #9040: [Code Style] Changed code to match the tvm code style conventions.
Posted by GitBox <gi...@apache.org>.
Mousius commented on pull request #9040:
URL: https://github.com/apache/tvm/pull/9040#issuecomment-923791118
Hi @mbrookhart / @Raghav-Chakravarthy,
I actually made this mistake in another PR (https://github.com/apache/tvm/pull/8951#discussion_r703703990), the actual rule is that all data members of a class should have the trailing `_` (https://google.github.io/styleguide/cppguide.html#Variable_Names) and should actually all be private with accessor functions if necessary (https://google.github.io/styleguide/cppguide.html#Access_Control).
@Raghav-Chakravarthy would it be possible for you to update this PR accordingly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Raghav-Chakravarthy commented on pull request #9040: [Code Style] Changed code to match the tvm code style conventions.
Posted by GitBox <gi...@apache.org>.
Raghav-Chakravarthy commented on pull request #9040:
URL: https://github.com/apache/tvm/pull/9040#issuecomment-939115045
@mbrookhart @Mousius
Sorry for the late response. I was busy with many school exams, and got a chance to look at the code this week.
All review comments have been addressed. Please let me know if anything else needs to be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #9040: [Code Style] Changed code to match the tvm code style conventions.
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9040:
URL: https://github.com/apache/tvm/pull/9040#issuecomment-941523414
@mbrookhart @Mousius could you take a look at this one? @Raghav-Chakravarthy could you fix the lint error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Raghav-Chakravarthy commented on pull request #9040: [Code Style] Changed code to match the tvm code style conventions.
Posted by GitBox <gi...@apache.org>.
Raghav-Chakravarthy commented on pull request #9040:
URL: https://github.com/apache/tvm/pull/9040#issuecomment-944837692
@Mousius @areusch
Thank you, I have fixed the linting errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #9040: [Code Style] Changed code to match the tvm code style conventions.
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9040:
URL: https://github.com/apache/tvm/pull/9040#issuecomment-941523414
@mbrookhart @Mousius could you take a look at this one? @Raghav-Chakravarthy could you fix the lint error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org