[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jtulach commented on a change in pull request #17: remove pack200 from nbm-maven-plugin

[GitBox <gi...@apache.org>]

jtulach commented on a change in pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17#discussion_r579283403



##########
File path: src/main/java/org/apache/netbeans/nbm/CreateClusterAppMojo.java
##########
@@ -319,7 +325,24 @@ else if ( path.endsWith( ".external" ) ) // MNBMODULE-138
                                             {
                                                 outstream = new BufferedOutputStream( new FileOutputStream( fl ) );
                                                 InputStream instream = jf.getInputStream( ent );
-                                                IOUtil.copy( instream, outstream );
+                                                if ( ispack200 )
+                                                {
+                                                    Pack200.Unpacker unp = Pack200.newUnpacker();

Review comment:
       Eric, if you hit this line on JDK14+, then you get a `LinkageError` - it'd be better to catch it or prevent it and fail the build with proper "maven build exception".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists