[GitHub] [arrow-datafusion] avantgardnerio commented on a diff in pull request #2741: improve: supports user-defined `scale_factor` for dbgen

[GitBox <gi...@apache.org>]

avantgardnerio commented on code in PR #2741:
URL: https://github.com/apache/arrow-datafusion/pull/2741#discussion_r901166971


##########
benchmarks/tpch-gen.sh:
##########
@@ -21,14 +21,15 @@
 pushd ..
 . ./dev/build-set-env.sh
 popd
-docker build -t datafusion-tpchgen:$DATAFUSION_VERSION -f tpchgen.dockerfile .
+
+docker build  -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION .
 
 # Generate data into the ./data directory if it does not already exist
 FILE=./data/supplier.tbl
 if test -f "$FILE"; then
     echo "$FILE exists."
 else
   mkdir data 2>/dev/null
-  docker run -v `pwd`/data:/data -it --rm datafusion-tpchgen:$DATAFUSION_VERSION

Review Comment:
   This change specifically breaks the volume mount for me. It appears the docker syntax expects the `imagename:version args` to come last, and putting it before the `-v` causes the `-v` to be interpreted as an argument to the script, not a volume mount. As such, the files are generated into an unbound volume and deleted when the container is destroyed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org