[GitHub] [cloudstack] rohityadavcloud commented on pull request #7810: Allow KVM overcommit to work without reducing minimum VM memory when vm ballooning is disabled

["rohityadavcloud (via GitHub)" <gi...@apache.org>]

rohityadavcloud commented on PR #7810:
URL: https://github.com/apache/cloudstack/pull/7810#issuecomment-1663855395

   I think here's how we deal with three issues:
   1. the centos7 blocker hopefully will be fixed if the revert committed caused that regression
   2. by default it passes the VM max memory via KVM guru, so libvirt computing resource uses the max VM memory when VM ballooning is disabled; and in env where VM ballooning somehow works the setting is not disabled and VM start with min. memory
   3. we change the default behaviour to have VM ballooning feature disable by default when the setting isn't defined. Existing env when they upgrade will continue to honour the setting in agent.properties; but users not reading docs will not get affected if they use commit memory in KVM env.
   
   please review and advise - @DaanHoogland @weizhouapache @harikrishna-patnala 
   
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org