You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "AboEl3iz (via GitHub)" <gi...@apache.org> on 2026/08/31 09:14:10 UTC
[PR] fix: disable aggregate dynamic filter when unsupported expressions are present (#24816) [datafusion]
AboEl3iz opened a new pull request, #24818:
URL: https://github.com/apache/datafusion/pull/24818
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #24816
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
Please explain the problem you are trying to solve in terms of the user-visible
behavior, rather than the implementation.
For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the
implementation. "COUNT(DISTINCT) returns wrong results when the column contains
nulls" is the user-visible problem.
-->
When an aggregate query contains both supported expressions (such as `MIN(a)`) and unsupported expressions (such as `MIN(c + 1)`), DataFusion previously built a dynamic filter using only the supported expressions.
Because all aggregate expressions in an `AggregateExec` share the same input scan stream, pushing a dynamic filter constructed from a subset of aggregate expressions prunes rows required by the unsupported expressions, producing incorrect aggregate results.
Aggregate dynamic filter pushdown must be an all-or-nothing optimization: if any aggregate expression in the `AggregateExec` cannot produce a valid dynamic filter predicate, dynamic filtering must be disabled (`dynamic_filter = None`) for that node.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Updated `AggregateExec::init_dynamic_filter` in `datafusion/physical-plan/src/aggregates/mod.rs` to return early when an aggregate argument is not a single `Column` reference.
- Added unit test `test_dynamic_filter_disabled_when_unsupported_expr_present` in `datafusion/physical-plan/src/aggregates/mod.rs`.
- Added integration test `dynamic_rg_pruning_disabled_when_unsupported_aggregate_present` in `datafusion/core/tests/parquet/dynamic_row_group_pruning.rs` reproducing issue #24816.
## What is the testing strategy for this PR?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
Briefly describe how this PR is tested, and point to the specific tests you added. For example: 'This new feature is covered by the `sqllogictest` cases added in `foo.slt`'.
If this PR does not add tests, explain why. For example, if the change is already covered by existing tests, please mention it.
You should also check the `codecov` bot reply on this PR to confirm the changed code is exercised.
-->
- Unit test: `test_dynamic_filter_disabled_when_unsupported_expr_present` in `datafusion-physical-plan` checks that `dynamic_filter` remains `None` when an unsupported expression like `MIN(a + 1)` is present.
- Integration test: `dynamic_rg_pruning_disabled_when_unsupported_aggregate_present` in `datafusion/core/tests/parquet/dynamic_row_group_pruning.rs` verifies that queries with `MIN(a), MAX(a), MAX(b), MIN(c + 1)` evaluate correctly (`71`) without row groups being pruned.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the `api change` label.
-->
No breaking API or user-facing changes. Correctness fix for aggregate queries with dynamic filter pushdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: disable aggregate dynamic filter when unsupported expressions are present (#24816) [datafusion]
Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 commented on PR #24818:
URL: https://github.com/apache/datafusion/pull/24818#issuecomment-5478759056
It's a duplicate of an earlier PR https://github.com/apache/datafusion/pull/24817 without coordination, so close it for now.
Please reopen if you can communicate with the author/reviewers and agree on proceeding with this PR instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: disable aggregate dynamic filter when unsupported expressions are present (#24816) [datafusion]
Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 closed pull request #24818: fix: disable aggregate dynamic filter when unsupported expressions are present (#24816)
URL: https://github.com/apache/datafusion/pull/24818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org