You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/08 00:22:29 UTC

[GitHub] [arrow] kou commented on pull request #10468: ARROW-12987: [C++][CI] Switch to bundled utf8proc with version 2.2 in Ubuntu 18.04 images

kou commented on pull request #10468:
URL: https://github.com/apache/arrow/pull/10468#issuecomment-856347802


   If we require utf8proc 2.2.0 or later, how about adding version check in CMake?
   
   ```diff
   diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
   index ff55936c2..1350f2745 100644
   --- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
   +++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
   @@ -2275,7 +2275,7 @@ macro(build_utf8proc)
    endmacro()
    
    if(ARROW_WITH_UTF8PROC)
   -  resolve_dependency(utf8proc)
   +  resolve_dependency(utf8proc REQUIRED_VERSION "2.2.0")
    
      add_definitions(-DARROW_WITH_UTF8PROC)
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org