You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2026/02/21 12:55:51 UTC
[PR] Configure Wagon from settings.xml [maven-site-plugin]
kwin opened a new pull request, #1233:
URL: https://github.com/apache/maven-site-plugin/pull/1233
This regressed with
https://github.com/apache/maven-site-plugin/commit/e414d23496e5bd3949774f2f8267e93eebf69f10
This closes #1217
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSITE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MSITE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MSITE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure Wagon from settings.xml [maven-site-plugin]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1233:
URL: https://github.com/apache/maven-site-plugin/pull/1233#issuecomment-4019744186
@kwin Please assign appropriate label to PR according to the type of change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure Wagon from settings.xml [maven-site-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1233:
URL: https://github.com/apache/maven-site-plugin/pull/1233#issuecomment-3994156948
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure Wagon from settings.xml [maven-site-plugin]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #1233:
URL: https://github.com/apache/maven-site-plugin/pull/1233#discussion_r2836163952
##########
pom.xml:
##########
@@ -284,6 +284,14 @@ under the License.
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- reusing component to configure Wagon -->
+ <dependency>
+ <groupId>org.apache.maven.resolver</groupId>
+ <artifactId>maven-resolver-transport-wagon</artifactId>
+ <version>1.4.1</version>
+ <!-- version shipping with Maven 3.6.3-->
+ <scope>compile</scope>
Review Comment:
Is the provided from the Maven Core classloader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure Wagon from settings.xml [maven-site-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1233:
URL: https://github.com/apache/maven-site-plugin/pull/1233#discussion_r2880972422
##########
pom.xml:
##########
@@ -284,6 +284,14 @@ under the License.
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- reusing component to configure Wagon -->
+ <dependency>
+ <groupId>org.apache.maven.resolver</groupId>
+ <artifactId>maven-resolver-transport-wagon</artifactId>
+ <version>1.4.1</version>
+ <!-- version shipping with Maven 3.6.3-->
+ <scope>compile</scope>
Review Comment:
> [@cstamas](https://github.com/cstamas) Do you remember what we have changed back them for Maven 3.9.x and Resolver 1.9.x/2.0.x?
Nope, but Wagon transport works even today in Maven 3 and even in 4... so unsure what site dropped and why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure Wagon from settings.xml [maven-site-plugin]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #1233:
URL: https://github.com/apache/maven-site-plugin/pull/1233#discussion_r2836163952
##########
pom.xml:
##########
@@ -284,6 +284,14 @@ under the License.
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- reusing component to configure Wagon -->
+ <dependency>
+ <groupId>org.apache.maven.resolver</groupId>
+ <artifactId>maven-resolver-transport-wagon</artifactId>
+ <version>1.4.1</version>
+ <!-- version shipping with Maven 3.6.3-->
+ <scope>compile</scope>
Review Comment:
Is this provided from the Maven Core classloader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure Wagon from settings.xml [maven-site-plugin]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #1233:
URL: https://github.com/apache/maven-site-plugin/pull/1233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure Wagon from settings.xml [maven-site-plugin]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #1233:
URL: https://github.com/apache/maven-site-plugin/pull/1233#discussion_r2880142418
##########
pom.xml:
##########
@@ -284,6 +284,14 @@ under the License.
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- reusing component to configure Wagon -->
+ <dependency>
+ <groupId>org.apache.maven.resolver</groupId>
+ <artifactId>maven-resolver-transport-wagon</artifactId>
+ <version>1.4.1</version>
+ <!-- version shipping with Maven 3.6.3-->
+ <scope>compile</scope>
Review Comment:
> Is this provided from the Maven Core classloader?
No (https://github.com/apache/maven/blob/maven-3.9.x/maven-core/src/main/resources/META-INF/maven/extension.xml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Configure Wagon from settings.xml [maven-site-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #1233:
URL: https://github.com/apache/maven-site-plugin/pull/1233#discussion_r2837432344
##########
pom.xml:
##########
@@ -284,6 +284,14 @@ under the License.
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- reusing component to configure Wagon -->
+ <dependency>
+ <groupId>org.apache.maven.resolver</groupId>
+ <artifactId>maven-resolver-transport-wagon</artifactId>
+ <version>1.4.1</version>
+ <!-- version shipping with Maven 3.6.3-->
+ <scope>compile</scope>
Review Comment:
@cstamas Do you remember what we have changed back them for Maven 3.9.x and Resolver 1.9.x/2.0.x=
##########
pom.xml:
##########
@@ -284,6 +284,14 @@ under the License.
<version>${mavenVersion}</version>
<scope>provided</scope>
</dependency>
+ <!-- reusing component to configure Wagon -->
+ <dependency>
+ <groupId>org.apache.maven.resolver</groupId>
+ <artifactId>maven-resolver-transport-wagon</artifactId>
+ <version>1.4.1</version>
+ <!-- version shipping with Maven 3.6.3-->
+ <scope>compile</scope>
Review Comment:
@cstamas Do you remember what we have changed back them for Maven 3.9.x and Resolver 1.9.x/2.0.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org