You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by dk...@apache.org on 2009/04/10 03:20:33 UTC

svn commit: r763854 - in /cxf/trunk: ./ common/common/src/test/java/org/apache/cxf/common/xmlschema/ parent/ rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/ rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/ rt/bindings/corba/s...

Author: dkulp
Date: Fri Apr 10 01:20:33 2009
New Revision: 763854

URL: http://svn.apache.org/viewvc?rev=763854&view=rev
Log:
Progress toward getting things working with IBM JDK

Modified:
    cxf/trunk/common/common/src/test/java/org/apache/cxf/common/xmlschema/ImportRepairTest.java
    cxf/trunk/parent/pom.xml
    cxf/trunk/pom.xml
    cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java
    cxf/trunk/rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/CorbaConduitTest.java
    cxf/trunk/rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReaderTest.java
    cxf/trunk/systests/src/test/java/org/apache/cxf/systest/type_test/AbstractTypeTestClient.java

Modified: cxf/trunk/common/common/src/test/java/org/apache/cxf/common/xmlschema/ImportRepairTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/common/common/src/test/java/org/apache/cxf/common/xmlschema/ImportRepairTest.java?rev=763854&r1=763853&r2=763854&view=diff
==============================================================================
--- cxf/trunk/common/common/src/test/java/org/apache/cxf/common/xmlschema/ImportRepairTest.java (original)
+++ cxf/trunk/common/common/src/test/java/org/apache/cxf/common/xmlschema/ImportRepairTest.java Fri Apr 10 01:20:33 2009
@@ -91,6 +91,12 @@
 
     @Test
     public void testImportRepairs() throws Exception {
+        if (System.getProperty("java.vendor").contains("IBM")) {
+            //the version of xerces built into IBM jdk won't work
+            //and we cannot get a good version unless we endorse it
+            return;
+        }
+        
         collection = new SchemaCollection();
         XmlSchema importingSchema = newSchema(IMPORTING_SCHEMA);
         XmlSchema baseTypeSchema1 = newSchema(BASE_TYPE_SCHEMA1);

Modified: cxf/trunk/parent/pom.xml
URL: http://svn.apache.org/viewvc/cxf/trunk/parent/pom.xml?rev=763854&r1=763853&r2=763854&view=diff
==============================================================================
--- cxf/trunk/parent/pom.xml (original)
+++ cxf/trunk/parent/pom.xml Fri Apr 10 01:20:33 2009
@@ -1155,6 +1155,8 @@
             <id>fastinstall</id>
             <properties>
                 <maven.test.skip>true</maven.test.skip>
+                <pmd.skip>true</pmd.skip>
+                <checkstyle.skip>true</checkstyle.skip>
             </properties>
         </profile>
 
@@ -1167,6 +1169,10 @@
 
         <profile>
             <id>nochecks</id>
+            <properties>
+                <pmd.skip>true</pmd.skip>
+                <checkstyle.skip>true</checkstyle.skip>
+            </properties>
         </profile>
 
         <profile>

Modified: cxf/trunk/pom.xml
URL: http://svn.apache.org/viewvc/cxf/trunk/pom.xml?rev=763854&r1=763853&r2=763854&view=diff
==============================================================================
--- cxf/trunk/pom.xml (original)
+++ cxf/trunk/pom.xml Fri Apr 10 01:20:33 2009
@@ -454,6 +454,9 @@
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-resources-plugin</artifactId>
                     <version>2.3</version>
+                    <configuration>
+                        <encoding>UTF-8</encoding>
+                    </configuration>
                 </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>

Modified: cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java?rev=763854&r1=763853&r2=763854&view=diff
==============================================================================
--- cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java (original)
+++ cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/CorbaConduit.java Fri Apr 10 01:20:33 2009
@@ -96,22 +96,30 @@
     public void prepare(Message message) throws IOException {    
         try {
             prepareOrb();
-            AddressType address = endpointInfo.getExtensor(AddressType.class);
-
+            
+            String address = null;
+            if (target != null) {
+                address = target.getAddress().getValue();
+            }
             if (address == null) {
-                LOG.log(Level.SEVERE, "Unable to locate a valid CORBA address");
-                throw new CorbaBindingException("Unable to locate a valid CORBA address");
+                AddressType ad = endpointInfo.getExtensor(AddressType.class);
+                if (ad != null) {
+                    address = ad.getLocation();
+                }
             }
             String ref = (String)message.get(Message.ENDPOINT_ADDRESS);
-            org.omg.CORBA.Object targetObject;
-            // A non-null endpoint address from the message means that we want to invoke on a particular
-            // object reference specified by the endpoint reference type.  If the reference is null, then
-            // we want to invoke on the default location as specified in the WSDL.
             if (ref != null) {
-                targetObject = CorbaUtils.importObjectReference(orb, ref);
-            } else {
-                targetObject = CorbaUtils.importObjectReference(orb, address.getLocation());
+                // A non-null endpoint address from the message means that we want to invoke on a particular
+                // object reference specified by the endpoint reference type.  If the reference is null, then
+                // we want to invoke on the default location as specified in the WSDL.
+                address = ref;
+            }
+            if (address == null) {
+                LOG.log(Level.SEVERE, "Unable to locate a valid CORBA address");
+                throw new CorbaBindingException("Unable to locate a valid CORBA address");
             }
+            org.omg.CORBA.Object targetObject;
+            targetObject = CorbaUtils.importObjectReference(orb, address);
             message.put(CorbaConstants.ORB, orb);
             message.put(CorbaConstants.CORBA_ENDPOINT_OBJECT, targetObject);
             message.setContent(OutputStream.class,

Modified: cxf/trunk/rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/CorbaConduitTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/CorbaConduitTest.java?rev=763854&r1=763853&r2=763854&view=diff
==============================================================================
--- cxf/trunk/rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/CorbaConduitTest.java (original)
+++ cxf/trunk/rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/CorbaConduitTest.java Fri Apr 10 01:20:33 2009
@@ -113,6 +113,13 @@
                          "SimpleCORBAPort");
 
         CorbaDestination destination = new CorbaDestination(endpointInfo, orbConfig);
+        
+        if (System.getProperty("java.vendor").contains("IBM")) {
+            //IBM requires it to activate to resolve it, but cannot
+            //activate on sun without more config
+            destination.activate();
+        }
+
         CorbaConduit conduit = new CorbaConduit(endpointInfo, destination.getAddress(), orbConfig);
         CorbaMessage message = new CorbaMessage(new MessageImpl());
         try {

Modified: cxf/trunk/rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReaderTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReaderTest.java?rev=763854&r1=763853&r2=763854&view=diff
==============================================================================
--- cxf/trunk/rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReaderTest.java (original)
+++ cxf/trunk/rt/bindings/corba/src/test/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReaderTest.java Fri Apr 10 01:20:33 2009
@@ -484,6 +484,11 @@
     
     @Test
     public void testReadFixed() {
+        if (System.getProperty("java.vendor").contains("IBM")) {
+            //The ORB in the IBM jdk doesn't support writing fixed
+            //to the stream.
+            return;
+        }
         OutputStream oStream = orb.create_output_stream();
         
         // create the following fixed

Modified: cxf/trunk/systests/src/test/java/org/apache/cxf/systest/type_test/AbstractTypeTestClient.java
URL: http://svn.apache.org/viewvc/cxf/trunk/systests/src/test/java/org/apache/cxf/systest/type_test/AbstractTypeTestClient.java?rev=763854&r1=763853&r2=763854&view=diff
==============================================================================
--- cxf/trunk/systests/src/test/java/org/apache/cxf/systest/type_test/AbstractTypeTestClient.java (original)
+++ cxf/trunk/systests/src/test/java/org/apache/cxf/systest/type_test/AbstractTypeTestClient.java Fri Apr 10 01:20:33 2009
@@ -59,6 +59,11 @@
     }
 
     public boolean shouldRunTest(String name) {
+        if (System.getProperty("java.vendor").contains("IBM")
+            && "GMonth".equals(name)) {
+            //the validator in ibm doesn't like this type.
+            return false;
+        }
         return true;
     }