You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by varunkumarm <gi...@git.apache.org> on 2017/09/20 19:59:22 UTC

[GitHub] cordova-plugin-inappbrowser pull request #99: inAppBrowser custom applicatio...

Github user varunkumarm commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/99#discussion_r140076603
  
    --- Diff: src/ios/CDVInAppBrowser.m ---
    @@ -783,6 +793,16 @@ - (void)showToolBar:(BOOL)show : (NSString *) toolbarPosition
     
     - (void)viewDidLoad
     {
    +    CGRect frame = [UIApplication sharedApplication].statusBarFrame;
    +    UIToolbar* bgToolbar = [[UIToolbar alloc] initWithFrame:frame];
    +    bgToolbar.barStyle = UIBarStyleDefault;
    +    bgToolbar.tintColor = [UIColor whiteColor];
    +    bgToolbar.barTintColor = [UIColor whiteColor];
    +//    [[UIBarItem appearance] setTitleTextAttributes:@{UITextAttributeTextColor : [UIColor whiteColor]}];
    +
    +
    +    [self.view addSubview:bgToolbar];
    +    
    --- End diff --
    
    @steinwelberg Can you please create the new merge request to get the essential part in? Clearly it looks like the extra code is causing the delay. It really helps to have the changes in the official branch than to fork and use. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org