You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "Aman-Mittal (via GitHub)" <gi...@apache.org> on 2025/10/30 12:07:19 UTC
[PR] FINERACT-2402 Replace the legacy Bitnami Kafka Docker image with the … [fineract]
Aman-Mittal opened a new pull request, #5131:
URL: https://github.com/apache/fineract/pull/5131
…official Apache Kafka image.
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3468916837
Tested: https://github.com/apache/fineract/actions/runs/18940493770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3468815992
Woah, that was fast! Has this been tested? Besides the indenting issue I mentioned, I'm seeing `:` separators instead of `=`... I'm not sure that'll work if these are standard/shell-like environment variable definitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3467733742
> @Aman-Mittal Please make sure the commit message is matching with the PR title!
Closing this request and raising PR again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the … [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3467712664
@Aman-Mittal Please make sure the commit message is matching with the PR title!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3468906700
Huh, apparently Docker [compose] allows both kinds of delimiters. I did a quick test and both worked fine.
So, LGTM too, and now I'll go crawl back in my cave and grumble alone about unnecessary indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal closed pull request #5131: FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image.
URL: https://github.com/apache/fineract/pull/5131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3468957355
Ah right, CI hit that, thanks. I still don't like the colons though... I think we're getting lucky there with some undocumented behavior. I'll look into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3467739475
@Aman-Mittal No need for that. you have already changed the commit message. it got updated the PR automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3471720266
@meonkeys Thanks for pointing it out, docker-compose indeed supports both : and = for parsing env files. However i should admit my mistake too. That i should use = instead of : in this project. As .env files format should be consistent across all project as older version docker may cause issue.
So generating new PR for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3469037866
Well how about that, looks like colons are supported: https://github.com/compose-spec/compose-go/blob/75fb1aba98ff8a944ebc5ea54f1054f1329e999c/dotenv/parser.go#L117
See also:
* https://github.com/compose-spec/compose-go/blob/75fb1aba98ff8a944ebc5ea54f1054f1329e999c/dotenv/godotenv_test.go#L713
* https://github.com/compose-spec/compose-go/blob/75fb1aba98ff8a944ebc5ea54f1054f1329e999c/dotenv/fixtures/custom.format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3468774140
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker merged PR #5131:
URL: https://github.com/apache/fineract/pull/5131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2402: Replace the legacy Bitnami Kafka Docker image with the official Apache Kafka image. [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #5131:
URL: https://github.com/apache/fineract/pull/5131#issuecomment-3473752112
@Aman-Mittal cool. I'd say don't bother creating a new PR for this, but go ahead if you want to. If you do, ping me and I'll review it for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org