You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2020/03/03 15:12:40 UTC

[flink] branch master updated: [hotfix][kinesis][build] Document why guava must not be relocated

This is an automated email from the ASF dual-hosted git repository.

chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 197991a  [hotfix][kinesis][build] Document why guava must not be relocated
197991a is described below

commit 197991aaccf1388b9ef86af1d0bba72a8c286a84
Author: Chesnay Schepler <ch...@apache.org>
AuthorDate: Tue Mar 3 15:25:23 2020 +0100

    [hotfix][kinesis][build] Document why guava must not be relocated
---
 flink-connectors/flink-connector-kinesis/pom.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/flink-connectors/flink-connector-kinesis/pom.xml b/flink-connectors/flink-connector-kinesis/pom.xml
index 388a978..edddad5 100644
--- a/flink-connectors/flink-connector-kinesis/pom.xml
+++ b/flink-connectors/flink-connector-kinesis/pom.xml
@@ -200,7 +200,8 @@ under the License.
 								</includes>
 							</artifactSet>
 							<relocations combine.children="override">
-								<!-- DO NOT RELOCATE GUAVA IN THIS PACKAGE -->
+								<!-- Do not relocate guava because it is exposed in the Kinesis API (KinesisProducer#addUserRecord).
+								 	Users may be using other affected API's, so relocations may break user-code -->
 								<relocation>
 									<pattern>com.google.protobuf</pattern>
 									<shadedPattern>org.apache.flink.kinesis.shaded.com.google.protobuf</shadedPattern>