You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/19 09:28:53 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #3967: noVNC console integration
davidjumani opened a new pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967
## Description
This feature provides novnc console for virtual machines.
It is developed based on noVNC 1.1.0
It includes changes in cloudstack :
(1) add a new websocket proxy to interact with the noVNC console
(2) a ConsoleProxyClient to read / write data from the vm vnc to the websocket.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
(1) Works on kvm / ubuntu / centos
(2) Works on xs 75
(3) Works on VMware 6.5
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #3967: noVNC console integration
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-631496443
@davidjumani please have a look at https://builds.apache.org/job/cloudstack-pr-analysis/10377/artifact/target/rat.txt or equivalent of any new PR. it seems we missed some licensing checks on this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb closed pull request #3967: noVNC console integration
Posted by GitBox <gi...@apache.org>.
andrijapanicsb closed pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb merged pull request #3967: noVNC console integration
Posted by GitBox <gi...@apache.org>.
andrijapanicsb merged pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #3967: noVNC console integration
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-628905729
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #3967: noVNC console integration
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-609112245
<b>Trillian test result (tid-1353)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 141082 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3967-t1353-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic_adapter_type.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 42 look OK, 41 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
test_DeleteDomain | `Error` | 0.69 | test_accounts.py
test_forceDeleteDomain | `Failure` | 0.69 | test_accounts.py
test_forceDeleteDomain | `Error` | 2.84 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 4.90 | test_accounts.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
ContextSuite context=TestAsyncJob>:setup | `Error` | 0.00 | test_async_job.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
ContextSuite context=TestDeployVMFromISO>:setup | `Error` | 0.00 | test_deploy_vm_iso.py
ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup | `Error` | 0.00 | test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestDeployVmWithUserData>:setup | `Error` | 0.00 | test_deploy_vm_with_userdata.py
test_01_create_iso_with_checksum_sha1 | `Error` | 65.76 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 65.64 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 65.36 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 65.36 | test_iso.py
test_01_create_iso | `Failure` | 1518.55 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3068.14 | test_iso.py
ContextSuite context=TestDomainsServiceOfferings>:setup | `Error` | 1515.69 | test_domain_service_offerings.py
test_01_add_delete_kubernetes_supported_version | `Error` | 156.01 | test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
test_list_clusters_metrics | `Error` | 1512.71 | test_metrics_api.py
test_list_vms_metrics | `Error` | 0.13 | test_metrics_api.py
test_nic_secondaryip_add_remove | `Error` | 1515.61 | test_multipleips_per_nic.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
test_delete_account | `Error` | 1515.34 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 0.05 | test_network.py
test_deploy_vm_l2network | `Error` | 0.06 | test_network.py
test_l2network_restart | `Error` | 1.14 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 3.38 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 0.88 | test_network.py
test_reboot_router | `Error` | 0.04 | test_network.py
test_releaseIP | `Error` | 0.36 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 0.40 | test_network.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1518.77 | test_projects.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.09 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_02_create_template_with_checksum_sha1 | `Error` | 5.12 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 5.13 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 5.11 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 5.12 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
test_01_volume_usage | `Failure` | 787.54 | test_usage.py
test_13_attachAndDetach_iso | `Failure` | 1511.49 | test_vm_life_cycle.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.89 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3967: noVNC console integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-629112455
<b>Trillian test result (tid-1531)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37093 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3967-t1531-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3967: noVNC console integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-628906086
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3967: [WIP - do not merge] noVNC console integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-629620292
Packaging result: ✔centos7 ✔debian. JID-1229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #3967: noVNC console integration
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-630778733
Travis log length exceeded - otherwise LGMT
Merging based on 2 x LGTMs, manual testing by 2 persons (Vladimir and me) and the regression test results passing 100%.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #3967: [WIP - do not merge] noVNC console integration
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #3967:
URL: https://github.com/apache/cloudstack/pull/3967#issuecomment-629705869
Packaging result: ✔centos7 ✔debian. JID-1230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org