You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "dschneider-pivotal (GitHub)" <gi...@apache.org> on 2019/02/02 01:15:52 UTC
[GitHub] [geode] dschneider-pivotal opened pull request #3155: do not
review
do not review, still a work in progress
[ Full content available at: https://github.com/apache/geode/pull/3155 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] BenjaminPerryRoss commented on pull request #3155:
GEODE-6291: change create mapping to define column and pdx field information
Posted by "BenjaminPerryRoss (GitHub)" <gi...@apache.org>.
We may want to add a third option here to attempt Serialization on the class to see if it can already be serialized to PDX - if so we could use that instead of creating a new Reflection Based Auto Serializer.
[ Full content available at: https://github.com/apache/geode/pull/3155 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #3155:
GEODE-6291: change create mapping to define column and pdx field information
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
[ pull request closed by dschneider-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/3155 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #3155:
GEODE-6291: change create mapping to define column and pdx field information
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
In that case output[0] is null which is the desired value when the condition is false
[ Full content available at: https://github.com/apache/geode/pull/3155 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #3155: GEODE-6291:
change create mapping to define column and pdx field information
Posted by "jchen21 (GitHub)" <gi...@apache.org>.
If the condition check is false, then output[0] won't be assigned.
[ Full content available at: https://github.com/apache/geode/pull/3155 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #3155:
GEODE-6291: change create mapping to define column and pdx field information
Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
It now tries to register the pdx meta data. If that fails (because pdx serialization is not configured for that class) then it attempts to serialize using its own ReflectionBasedAutoSerializer.
[ Full content available at: https://github.com/apache/geode/pull/3155 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org